Add permission to allow declining own translations

The OGUR migration issue at #652038: Migrate permissions to og_user_roles, instead of our own code resulted in direct use of user_access() all around, so this will need a reroll. Additionally to that, I'd have the following remarks:

- let's not hardcode access for declining own suggestions, some users might not want that; instead break out "moderate own suggestions" to "decline own suggestions" and "approve own suggestions"
- your solution handles this on the individual AJAX output, but not on the mass moderation screen; allowing people to mass-decline their suggestions would have this nice side effect to have access to the moderation page and have an overview of all outstanding suggestions one has in the system, so they can directly vet their contributions there, so it would be vital to make this more granular workflow work there

Great, this helps people removing their own typos.

Marked #331051: Delete own suggestion as duplicate of this issue.

Retitled to be more accurate in terms of what it does.

Or to be more precise, what it would be good to do :)

implemented the requirements in comment #1

I guess some other required modifications are needed:
additional update functions for
l10n_community.install
l10n_groups.install

additional test
l10n_community.test

From the looks of the moderate.inc code, this patch allows people who can moderate others and decline their own suggestions to also approve their own suggestions due to how the conditionals are formed.

Generally, I'd suggest to postpone these big patches which touch considerable amounts of code in translate.inc to after we switched over to the 2.x branch, which introduces significant changes in the translate.inc code.

upps :D

it only add & changed to a new permission. That means

moderate own suggestions = decline own suggestions (in some sections)

so everyone could decline, also approve their own suggestions.

Removed hunks.

This would be a nice feature. Often users submit a suggestion and one minute later makes a new one. If the user could decline the faulty suggestions, then there is less work for the administrators.

I applied the patch in #13 and it works great!

Go for it, I'd like to decline some of my wrong suggestions, I've added some years ago.

Nothing new, just a reroll.

I bet it is v3 now or D7 first... anything getting it commit is great :)

Re-rolled the patch for 6.x-3.x-dev

And a D7 patch too. I've marked it do-not-test as it will fail on this D6 branch.

Added tests, will be committed if testbot is ok.

So this somehow crept into the codebase on 7 :D See #2575563: Test and make it possible to grant 'Decline own suggestions' on a group level, so it can be granted on localize.drupal.org. Was this committed after all?

Hi,
any update on this ?
it can be critical to have the right to delete "own non validated suggestions" especially if by mistake some personal data unrelated with source string was suggested. Once submitted, we have no way to correct the mistake :/

This would seem very useful to easily improve the quality of suggestion imports and facilitate the work of validators to give simple contributors the right to cancel their own suggestions.
It seems that there is a role of "self-moderator". If this is the case, why not assign it automatically or in any case facilitate its request.
Thank you