If I enable a vocabulary the terms are shown in invalid HTML code. There is something wrong the the UL > LI's. Need to investigate further... it also have the "tree" class that should be themable.

CommentFileSizeAuthor
#14 site_map_652478-14.patch8.68 KBtic2000

Comments

frjo’s picture

frjo commented

There used to be some small validation errors with the ul nesting but they should have been fixed.

Is't the "tree" in <div class="tree">
you mean? That div locks redundant to me, probably something left over from older versions. Just committed a patch that removes that div and makes some followup changes to the CSS file.

Please try it out and report back here.

hass’s picture

hass commented

That great - thank you.

The DIV looked to be redundant to me, too. Are you able to give the UL a class name so that themers are able to style the it (like we have done for the menu)? I tried to understand the taxonomy tree building code yesterday and thought it may be a good idea to make it easier to understand, but I was holded back with other things... I have simply not understood without digging deeper what you are doing there... maybe there are theme functions that can be reused!?

hass’s picture

hass commented

There is no commit that changes the UL?

frjo’s picture

frjo commented

The nested UL validation problem was fixed some time ago.

A clss for the UL is not needed I think. Use the surrounding div with classes like "sitemap-terms sitemap-terms-[vid]" instead.

 .sitemap-terms ul {
}
hass’s picture

hass commented

I used latest dev and the bug was inside and not fixed... Need to retest.

hass’s picture

hass commented

Verified again, but is not fixed in latest DEV

line 311 column 9 - Error: end tag for "ul" omitted, but OMITTAG NO was specified
line 297 - Info: start tag was here
line 313 column 4 - Error: end tag for element "li" which is not open
line 314 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 321 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 329 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 330 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 331 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 332 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 357 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 458 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 459 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 460 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 461 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 470 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 526 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 585 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 619 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 620 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 625 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 651 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 661 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 662 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 747 column 9 - Error: end tag for "ul" omitted, but OMITTAG NO was specified
line 663 - Info: start tag was here
line 748 column 4 - Error: end tag for element "ul" which is not open
line 749 column 4 - Error: end tag for element "li" which is not open
line 750 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 751 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 757 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 758 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 787 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 788 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 789 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 795 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 796 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 797 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 798 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 799 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 800 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 801 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 802 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 819 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 825 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 841 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 862 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 863 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 864 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 886 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 898 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 909 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 910 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 934 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 1009 column 9 - Error: end tag for "ul" omitted, but OMITTAG NO was specified
line 935 - Info: start tag was here
line 1010 column 4 - Error: end tag for element "ul" which is not open
line 1011 column 4 - Error: end tag for element "li" which is not open
line 1012 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 1040 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 1047 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 1153 column 9 - Error: end tag for "ul" omitted, but OMITTAG NO was specified
line 1048 - Info: start tag was here
line 1154 column 4 - Error: end tag for element "ul" which is not open
line 1155 column 4 - Error: end tag for element "li" which is not open
line 1156 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 1157 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 1167 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 1168 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 1176 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 1177 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 1196 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 1197 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 1205 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 1218 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 1231 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 1232 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 1233 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 1242 column 4 - Error: end tag for element "ul" which is not open
frjo’s picture

frjo commented

Can you put a link to this site map or post a chuck of the HTML?

I tested my own site map pages and found no problems with them.

hass’s picture

hass commented

First of all a vocabulary without any terms. Does it makes sense to show it? I think this should only outputted of it have terms.

<div class="sitemap-box sitemap-terms sitemap-terms-2">
  <h2 class="title">Sitemap Test</h2>
  <div class="content"/>
</div>

Vocabulary with 3 levels

<div class="sitemap-box sitemap-terms sitemap-terms-2">
  <h2 class="title">Sitemap Test</h2>
  <div class="content">
    <ul>
      <li>a. Level 1 (0)
      <ul>
        <li>a. Level 2 (0)
          <ul>
            <li>a. Level 3 (0)</li>
          </ul>
        </li>
      </ul>
      </li>
      <li>b. Level 1 (0)</li>
      <li>c. Level 1 (0)</li>
      <li>d. Level 1 (0)</li>
    </ul>
  </div>
</div>

Error:

line 244 column 9 - Error: end tag for "ul" omitted, but OMITTAG NO was specified
line 239 - Info: start tag was here
line 246 column 4 - Error: end tag for element "li" which is not open
line 247 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 248 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 249 column 3 - Error: document type does not allow element "li" here; missing one of "ul", "ol", "menu", "dir" start-tag
line 250 column 4 - Error: end tag for element "ul" which is not open
frjo’s picture

frjo commented

That snippet of HTML looks valid (XHTML 1.0 Strict) to me and when I check it on http://validator.w3.org/ it reports no problems.

hass’s picture

hass commented

Maybe Firebug changed something... here is the raw copy from Firefox source code... W3C validator also shows me the errors.

<h2 class="title">Sitemap</h2>
<div id="site-map" class="site-map">
<div class="sitemap-box sitemap-front">
<h2 class="title">Startseite</h2>
<div class="content">
<a href="/">Startseite von <em>example.com</em></a>
</div>
</div>
<div class="sitemap-box sitemap-terms sitemap-terms-2">
<h2 class="title">Sitemap Test</h2>
<div class="content">
<ul>
<li>a. Level 1 (0)
<ul>
<li>a. Level 2 (0)
<ul>
<li>a. Level 3 (0)</li>
</ul>
</li></li>

</ul>
</li>
<li>b. Level 1 (0)</li>
<li>b. Level 2 (0)</li>
<li>b. Level 3 (0)</li>
</ul>
</div></div></div>
frjo’s picture

frjo commented
Assigned: Unassigned » frjo

Yes, now I see the errors also.

This is tricky, I will try to fix this bug but any help it appreciated.

hass’s picture

hass commented

It may be a good odea to refactor this function and if possible - reuse some core functions or at least copy them over as a base... It looked a bit difficult to me too…

hass’s picture

hass commented

Marked #747022: html problem on menus as duplicate

tic2000’s picture

tic2000 commented
Status: Active » Needs review
StatusFileSize
new site_map_652478-14.patch8.68 KB
tic2000’s picture

tic2000 commented

Patch still applies after #730992: Options for title of sitemap page was committed.

tic2000’s picture

tic2000 commented

No review after more than 5 weeks?

frjo’s picture

frjo commented

Sorry tic2000, has been a busy spring summer. It's on my todo list, I promise.

frjo’s picture

frjo commented

This patch needs to be rerolled against latest 6--2-dev.

There seems also to be a conflict between the use of $class in this patch and the old use of $class in theme_site_map_box().