See this code, create the checkbox:

  $allow_public = variable_get('forum_allow_public', 0);
  if (($allow_public && (user_access('make forums public')) || user_access('administer forums'))) {
    $form['make_public'] = array(
      '#type' => 'checkbox',
      '#title' => t('Make forum public'),
      '#description' => t('This will allow non-group members to <em>view</em> this forum.'),
      '#default_value' => FALSE, // <<<<<<<<<<<<< Senseless
      '#access' => 0,  // <<<<<<<<<<<<< Bullshit
    );
  }

With #access => 0

No one can see this checkbox. This is not a feature, or do you??

Next thing:
'#default_value' => FALSE,

What's that? FALSE as default? This is senseless.

Dear maintainer

Why do you contribute a module with such a strange code and functional defects? That is not okay!

I think many people have problems and frustrations with the module OG Forum.

Problems and frustrations, functional defects?

Some examples, not all, of things that do not work

  • Private group forums will be displayed in the list of public forums.
  • A group manager can (within the configured limits) not create a new group forums. For this action because the link does not exist.
    He uses the path manually og_forum / manage / add / gid / tid can create a new group forum.
  • The limit for the creation of group forums will be ignored if a group manager creates a new group forum.
  • The checkbox public/private status not working. After saving the form its value is not in the DB table. The corresponding value is always 0.

Last Case

Drupal has a code style guide. Many parts of the code of the modules do not correspond to the drupal code style. But this is probably the smallest problem with the module OG Forum.

Last question

When will it be that the module works as it should be?

Kind regards
Quiptime

CommentFileSizeAuthor
#6 og_forums-6.x-1.0-dev.tar_.gz172.24 KBquiptime

Comments

quiptime’s picture

Dear maintainer,

i worked on OG Forum. The code is completely re-structured - more readable and drupal style guide compliant. Many, many bugs are fixed.

But there is still something to do: Good usability and functionality when a group manager creating/editing OG Forums. My code implements a flat style of the forum structure - all OG Forums in the same folder.

My changes to the code are so extensive that it is not advisable to create a patch.
Do you have interest in my version of "OG Forum"?

SeanBannister’s picture

Status: Fixed » Active

--- Posted to wrong issue ---

SeanBannister’s picture

Status: Active » Fixed
SeanBannister’s picture

--- Sorry, updated wrong issue ---

AntiNSA’s picture

subscribe

quiptime’s picture

StatusFileSize
new172.24 KB

My fork of OG Forum - OG Forum Reloaded. The module name with s - og_forums.

tallsimon’s picture

This is very interesting, thank you quiptime. I would like to know if this is likely to be adopted and/or supported before I decide to use this in my beta site.

Apfel007’s picture

HI quiptime,
got this error.. what could that be?

Warning: Call-time pass-by-reference has been deprecated in /www/drupal/sites/xx/modules/og_forums/og_forums.admin.inc on line 219

Warning: Call-time pass-by-reference has been deprecated in /www/drupal/sites/xx/modules/og_forums/og_forums.admin.inc on line 219

Warning: Call-time pass-by-reference has been deprecated in /www/drupal/sites/xx/modules/og_forums/og_forums.admin.inc on line 227

Warning: Call-time pass-by-reference has been deprecated in /www/drupal/sites/xxx/modules/og_forums/og_forums.admin.inc on line 227

kompressaur’s picture

subsribe...subscribe

Apfel007’s picture

you have to change this lines and get rid of the "&". Google says something about old/php4 code style?! (better my if I'm wrong)

vegantriathlete’s picture

Status: Active » Closed (won't fix)