Autosave support for CKEditor module is in this issue.

CommentFileSizeAuthor
#12 ckeditor-autosave.patch2.33 KBjcisio

Comments

mephir’s picture

Please check our patch and apply.
Thanks for all.

nancydru’s picture

Status: Active » Needs work

That patch should be moved to this issue queue.

twod’s picture

Status: Needs work » Closed (won't fix)

No it shouldn't. That patch violates the concept of Wysiwyg module. It's designed to provide a common interface for all editors it supports, without the need for modules like this one to write custom code for each editor. This module already supports what's likely to become part of that interface once #614146: Drupal.wysiwyg.editor.instance needs additional methods is committed. If that Wysiwyg module patch gets updated with support for the new methods in the CKEditor implementation, this module will work without any modifications at all. Hence, this should be a "won't fix".

jcisio’s picture

Version: 6.x-2.5 » 6.x-2.7
Status: Closed (won't fix) » Active

Even it was said in http://drupal.org/node/334925#comment-2693602 that Autosave doesnot support individual editor, could you change your mind? CKEditor+FCKeditor has a userbase of about 100k, won't you support them (1/3 of all Drupal users)? Let people have a choice!

And don't hold your breath. The patch mentioned in #3 has been stuck for 11 months, while the patch for CKEditor here is only 2 KB.

nancydru’s picture

Did this work with CKEditor or TinyMCE in version 1.x? I cannot wait for WYSIWYG 3.x (which is not even on the project page).

jcisio’s picture

I tested and it worked with CKEditor 1.1. And it currently works with CKEditor 1.2 (none of my visitors complain about it).

nancydru’s picture

We're currently on CKEditor 3.1+ and TinyMCE 3.3.9.2 and WYSIWYG 6.x-2.x-dev.

jcisio’s picture

Euh, this patch is for CKEditor.module, not WYSIWYG.

jcisio’s picture

- delete duplicate post -

twod’s picture

If I remember correctly, I was pointed here by someone who wanted AutoSave support for CKEditor under Wysiwyg module, in which case focusing on the issue in #3 is the way to go.
I apologize for missing "module" after "CKEditor" and closing this on the assumption it was meant for Wysiwyg module without verifying that.

Yes, the Wysiwyg issue on the same topic has been stuck for quite a while, but everyone are welcome to invest time in it. I have been swamped by other tasks and can barely keep up with the support requests. But if it gets done I could committ it right away if Sun agrees to extend the API before 3.x. Let's keep that discussion to the issue in #3 though.

As for interaction with just ckeditor.module, this patch looks good.

jcisio’s picture

Status: Active » Reviewed & tested by the community

Marking it as RTBC then.

jcisio’s picture

StatusFileSize
new2.33 KB

Reupload the patch to this issue.

nancydru’s picture

Sorry, I guess I got people confused with my question. Let me try to clarify it.

WYSIWYG's policy: "After committing this to 7.x-3.x, we might consider to backport it to 6.x-3.x .... 7.x-3.x isn't even listed on the project page. We have no idea when, or if, the patch to that module might be done and then perhaps back-ported. Therefore, we have no idea whether or not this feature will ever be available to the AutoSave 6.x-2.x branch.

Since it seems to me that it was available in the 6.x-1.x branch, I am considering downgrading to that branch, with, or without, WYSIWYG. We currently use the CKEditor MODULE; I have only been testing WYSIWYG and TinyMCE because someone said that it does currently support AutoSave somehow.

I need a functional AutoSave with a WYSIWYG editor of some kind (preferably CKEditor). At this point, I don't care how we get there. It seems that this patch would be the easiest and most reliable. I do not want to leave the customer with a patched module that the maintainer would likely break in the next release, even if unintentionally.

jcisio’s picture

It is another issue, which is considered fixed at #612830: Autosave + WYSIWYG API + TinyMCE it is possible?, with the commit http://drupal.org/cvs?commit=280320 a year ago (well, always waiting for WYSIWYG patch).

And currently, liquidcms said that Autosave supports only WYSIWYG in its 2.x branch. I do not consider downgrade is a solution. We'll ping him and ask to commit this patch, won't we?

Or work on a patch on CKEditor module #653246: Support for CKEditor and it will likely be committed.

Hiroaki’s picture

subscribing

I hope this fix gets maintainers attention and get committed.
It seems these WYSIWYG editor related issues have been here for ages...

liquidcms’s picture

Status: Reviewed & tested by the community » Closed (duplicate)