Did anyone else try gmaps with php 5.3? I have some trouble with respect to the gmaps_content submodule. The input map does not show markers, static maps display only shows 0,0 or the default center point, although the correct values are stored.

I did not encounter any error messages thats why debugging seemed quite hard. To narrow down the problems, anyone else tried gmaps with php 5.3?

CommentFileSizeAuthor
#11 gmaps_php53_2.patch7.55 KBlupus78
#10 gmaps_php53_1.patch8.02 KBlupus78

Comments

xmarket’s picture

xmarket commented
Title: PHP 5.3 compatibility of gmaps_content » PHP 5.3 incompatibility
Category: support » bug
Priority: Normal » Minor

It seems gmaps has php 5.3 incompatibility problems.

I'm marking this bug as a minor beacuse of the System requirements of D6.

price9001’s picture

price9001 commented

I'm also having 5.3 compatibility issues.

Would very much appreciate if someone could patch this or include a fix in the latest dev version!

josuealcalde’s picture

josuealcalde commented

We are also having problems with this.
It makes gmaps fail in 5.3 php and since drupal 6.14 already supports php 5.3, I think the priority should change.
Any way, it is not hard to correct and I will make a patch when I have time.

xmarket’s picture

xmarket commented
Priority: Minor » Normal
digi24’s picture

digi24 commented

-- edit --

Yacko’s picture

Yacko commented

I'm also having 5.3 compatibility issues.

Error in /admin/gmaps/map/x/edit :
warning: Parameter 2 to gmaps_map_form() expected to be a reference, value given in /media/Donnees/Programmation/www/nantes-energiologie/includes/form.inc on line 376.

KhaledBlah’s picture

KhaledBlah commented

I have the same problem as #6 and I use PHP 5.3.2 on Ubuntu 10.04.

deepakgoyal’s picture

deepakgoyal commented

Yup i am having the same problem and my error is

warning: Parameter 2 to gmaps_icon_form() expected to be a reference, value given in /opt/lampp/htdocs/fishshoppingcart/includes/form.inc on line 376.

look forward for the solution

joshuabud’s picture

joshuabud commented
Component: Code » Documentation

I'm having this same issue. I had thought it was fixed but it's not.

lupus78’s picture

lupus78 commented
StatusFileSize
new gmaps_php53_1.patch8.02 KB

I've managed to make Gmaps work under PHP5.3

Attached a patch, which is probably not full, as there can be a few other non compatible function calls. I haven't used static maps, and i thing those calls would still fail on php 5.3

The patch is made againts, the dev version.

I know the patch is not nicely formed, but i don't have CVS currently.

lupus78’s picture

lupus78 commented
StatusFileSize
new gmaps_php53_2.patch7.55 KB

I've fixed the patch file, so it would apply more easily to dev version.

hansrossel’s picture

hansrossel commented
Component: Documentation » Code
Status: Active » Needs review
IetC_development’s picture

IetC_development commented

Patch #11 worked fine for me.

itserich’s picture

itserich commented

I am trying Google Map Tools for the first time and am having some odd display issues.

When trying to configure GMaps Address as a CCK field, the GMaps settings field do not expand and collapse correctly (only one field will expand at a time, and it will not collapse).

When creating content the map displayed in the GMaps Address field is very short, not even the height of the control arrows.

I did recently upgrade to PHP 5.3 and am wondering if that is the cause of these issues.

xmarket’s picture

xmarket commented

"Parameter n to xy() expected to be a reference" bugs have been fixed in dev.

roball’s picture

roball commented
Status: Needs review » Closed (fixed)

Then the issue seems to be closed.