No first, last li's; makes it hard to style

CommentFileSizeAuthor
#6 653514-dynamic_persistant_menu-first-last.patch2.82 KBmrfelton
#2 template.txt3.98 KBchl-dev
#2 dynamic-persistent-menu_first-last.patch3.03 KBchl-dev
dynamic_persistent_last.patch2.71 KBhefox

Comments

yrocq’s picture

yrocq commented
Version: 6.x-1.2 » 6.x-2.x-dev
Assigned: Unassigned » yrocq

New features will be implemented in 2.x

chl-dev’s picture

chl-dev commented
StatusFileSize
new dynamic-persistent-menu_first-last.patch3.03 KB
new template.txt3.98 KB

Hello,

little problem with the patch when the first or last is "hidden".

I came accross this problem, so instead of patching the module I did an override for my theme.
- For those interested, you have to add the function of the TXT to your template.php.
- In case it can be useful for the next version, I also post a "patch" to show it's mainly a copy of the official function with a filter on the hidden items and a counter,

Interested in any advice.
Hope it can helps.

Katrina B’s picture

Katrina B commented

Would really like to see this implemented soon so I don't have to keep patching the module every time there's a new release.

hefox’s picture

hefox commented
Status: Active » Needs work

Changing status to reflect current state based on comment 2

Katrina B’s picture

Katrina B commented

Any progress on this?

mrfelton’s picture

mrfelton commented
Status: Needs work » Needs review
StatusFileSize
new 653514-dynamic_persistant_menu-first-last.patch2.82 KB

Patch against latest in git.

yrocq’s picture

yrocq commented
Status: Needs review » Fixed

Commited in 6.x-2.x. Thanks !

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.