Since updating to 6x-1.8, publication years "9999" and "9998" are showing in the separator bar instead of "Submitted" and "In Press".

I think this is related to a change around line 500 in the biblio.pages.inc file. It's loading the node, then resetting all the values in the node object back to the raw values returned by db_fetch_object(). My guess is that this is overwriting the "Submitted" and "In Press" representations with the raw "9999" or "9998" values. I don't know enough about the biblio module to feel confident in a fix, but hopefully this puts someone on the right track.

Comments

rjerome’s picture

Indeed you are correct. If you comment out (// ... ) lines 500 and 502 I think it should work correctly again.

Ron.

michal.sorf’s picture

Hi Ron,

could you specify what exactly do with these lines? Simple commenting out doesn't work on my site ...

Thanks,

Michal

rjerome’s picture

You could try deleting them, it that doesn't work then you must have found another issue.

Just for some context, here are the lines in question, you should delete the lines above and below the line with "$node = node_load($node->nid);"

  // Reset separator bar status for repeated calls to biblio_db_search.
  _biblio_category_separator_bar(NULL, NULL, TRUE);

  while ($node = db_fetch_object($result)) {
    $count++;
// delete this line   foreach($node as $key => $value) $node_input[$key] = $value; // save any incoming values such as type name or keyword
    $node = node_load($node->nid);
//  delete this line  foreach($node_input as $key => $value) $node->$key = $value; // now add the incoming values back to the new node object

    if (variable_get('biblio_hide_bibtex_braces', 0)) $node->title = biblio_remove_brace($node->title);
    if (variable_get('biblio_fix_isi_links', 0)) biblio_fix_isi_links($node);


    // output separator bar if needed
    $content .= _biblio_category_separator_bar($attrib, $node);

Ron.

ShutterFreak’s picture

Thank you! This solved my problem as well.

rjerome’s picture

I'm going to make a new release which fixes this issue within the next week or so.

Ron.

rjerome’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.