Hi.
After upgrading over the weekend and enabling caching in each view, I'm seeing the above error in my logs from Boost. A complete sample from the logs is:
Dec 7 08:34:30 crca drupal: http://www.crca.org.au|1260174870|boost|65.55.207.78|http://www.crca.org.au/Resources/WordOfSalvation/TheSevenTrumpets||0||There are php errors on this page, preventing boost from caching. ERROR: Array [type] => 2048 [message] => Declaration of views_handler_filter_many_to_one::init() should be compatible with that of views_handler_filter::init() [file] => /home/crca-website/public_html/sites/all/modules/views/handlers/views_handler_filter_many_to_one.inc [line] => 0 Lookup Error Type Turn Off Error Checking
Regards,
NIgel
Comment | File | Size | Author |
---|---|---|---|
#38 | 653628-38.patch | 6.5 KB | vijaycs85 |
#18 | cck.diff | 928 bytes | keinstein |
#18 | date_handler_field_multiple.inc_.diff | 704 bytes | keinstein |
#13 | views.diff | 14.3 KB | keinstein |
#9 | views-653628.patch | 13.19 KB | dawehner |
Comments
Comment #1
dawehnerhttp://drupal.org/cvs?commit=299206
This was fixed by merlinofchaos.
Comment #2
Nigel CunninghamGreat. Should I try devel then? (Assuming there is one - haven't looked yet)
Comment #3
dawehneryes there is. But the dev version needs perhaps 6 or 12 hours to be build. Perhaps its not fixed in the latest dev version.
Comment #4
merlinofchaos CreditAttribution: merlinofchaos commentedAck, I got distracted after the commit and did not post the patch that I used here:
Comment #5
Nigel CunninghamIt looks to me like there are similar issues with some other code:
After that one is out of the way, i'm now seeing:
http://www.crca.org.au|1260266705|boost|67.195.112.126|http://www.crca.org.au/Resources/WordOfSalvation?page=10||0||There are php errors on this page, preventing boost from caching. ERROR: Array [type] => 2048 [message] => Declaration of views_handler_filter_term_node_tid::value_validate() should be compatible with that of views_handler_filter::value_validate() [file] => /home/crca-website/public_html/sites/all/modules/views/modules/taxonomy/views_handler_filter_term_node_tid.inc [line] => 0 Lookup Error Type Turn Off Error Checking
and
http://www.crca.org.au|1260248779|boost|66.249.71.148|http://www.crca.org.au/AboutUs/WhoWeAre/Locations/Blaxland||0||There are php errors on this page, preventing boost from caching. ERROR: Array [type] => 2048 [message] => Declaration of views_handler_filter::options_validate() should be compatible with that of views_handler::options_validate() [file] => /home/crca-website/public_html/sites/all/modules/views/handlers/views_handler_filter.inc [line] => 0 Lookup Error Type Turn Off Error Checking
Regards,
Nigel
Comment #6
dagmarYes, I found 2 more. Thanks for reporting.
Comment #7
Nigel CunninghamThanks.
That seems to have gotten rid of the errors. Unfortunately I've now discovered another (unrelated) bug - will go see if anyone has reported it already.
Comment #8
Nigel CunninghamHi again.
Got some more, I'm afraid...
Dec 11 02:19:07 crca drupal: http://www.crca.org.au|1260497947|boost|67.195.112.126|http://www.crca.org.au/category/Tags/resurrectionofChrist||0||There are php errors on this page, preventing boost from caching. ERROR: Array [type] => 2048 [message] => Declaration of views_handler_filter::options_submit() should be compatible with that of views_handler::options_submit() [file] => /home/crca-website/public_html/sites/all/modules/views/handlers/views_handler_filter.inc [line] => 0 Lookup Error Type Turn Off Error Checking
Dec 11 02:22:11 crca drupal: http://www.crca.org.au|1260498131|boost|202.148.231.138|http://www.crca.org.au/|http://www.google.com.au/search?hl=en&source=hp&q=CRCA&meta=&aq=f&oq=|0||There are php errors on this page, preventing boost from caching. ERROR: Array [type] => 2048 [message] => Declaration of views_plugin_style_default::options() should be compatible with that of views_object::options() [file] => /home/crca-website/public_html/sites/all/modules/views/plugins/views_plugin_style_default.inc [line] => 0 Lookup Error Type Turn Off Error Checking
Dec 11 02:22:11 crca drupal: http://www.crca.org.au|1260498131|boost|202.148.231.138|http://www.crca.org.au/|http://www.google.com.au/search?hl=en&source=hp&q=CRCA&meta=&aq=f&oq=|0||There are php errors on this page, preventing boost from caching. ERROR: Array [type] => 2048 [message] => Declaration of views_handler_field_user::init() should be compatible with that of views_handler_field::init() [file] => /home/crca-website/public_html/sites/all/modules/views/modules/user/views_handler_field_user.inc [line] => 0 Lookup Error Type Turn Off Error Checking
Dec 11 02:25:51 crca drupal: http://www.crca.org.au|1260498351|boost|65.55.207.51|http://www.crca.org.au/Resources/WordOfSalvation/ByTitle?page=1||0||There are php errors on this page, preventing boost from caching. ERROR: Array [type] => 2048 [message] => Declaration of views_handler_filter_user_name::value_submit() should be compatible with that of views_handler_filter_in_operator::value_submit() [file] => /home/crca-website/public_html/sites/all/modules/views/modules/user/views_handler_filter_user_name.inc [line] => 0 Lookup Error Type Turn Off Error Checking
Regards,
Nigel
Comment #9
dawehnerI greped and found some other ones.
all options_submit
all init
all value_submit
based on dagmars patch for views 3.x
Comment #10
merlinofchaos CreditAttribution: merlinofchaos commentedSo I should use #6 for Views 2 and #9 for Views 3? Or do we need a separate patch for Views 2?
Comment #11
dawehner#9 Fixes much more places then #6. So #9 would have to be applied to 2.x too.
Comment #12
merlinofchaos CreditAttribution: merlinofchaos commentedCommitted to 3.x; however, this does not apply to 2.x. It probably should be rerolled for 2.x (and possilby 7.x-3.x?)
Comment #13
keinstein CreditAttribution: keinstein commentedadaption of views-653628.patch to 6.x-2.10 I didn't search for additional places.
there is still an error message “Declaration of views_plugin_row::options_validate() should be compatible with that of views_plugin::options_validate() E:\esg\sites\all\modules\views\plugins\views_plugin_row.inc:135”, but I don't know whats wrong there.
Comment #14
keinstein CreditAttribution: keinstein commentedI'm not sure, if I interpreted value_validate right. I've decided to use the form
function value_validate($form, &$form_state);
This triggers #774270 Can someone confirm that this interpretation is right?
Comment #15
dawehnerUpdate ststus
Comment #16
Nigel CunninghamTesting it now against views-dev from a day or two ago.
Comment #17
Nigel CunninghamStill getting some:
views_plugin_access_role::options_submit() should be compatible with that of views_plugin_access::options_submit()
views_handler_filter_user_name::value_submit() should be compatible with that of views_handler_filter_in_operator::value_submit()
(Unrelated, I assume) rules_data_type_string::get_default_input_form() should be compatible with that of rules_data_type::get_default_input_form()
Comment #18
keinstein CreditAttribution: keinstein commentedI have another patch. This might be my last one on this issue. So don't rely on me, please.
There was one pre_render(&value) function somewhere in the views code. At a first glance I didn't know, how to avoid that. So I changed all occurrences of pre_render to be called by reference. This affects also the cck and the date module. I attach some prelimnary patches here. If you decide to follow my decition, they must be forwarded to the corresponding projects.
Comment #19
dawehnerPlease make a patch from the root of views. This is really hard to apply
Comment #20
dawehnerI did this for 7.x-3.x too, i think.
Comment #21
Kristen PolI'm seeing these errors when using authcache, and I'm not clear on the status of this... Is there a 6.x release that includes the fixes? Or do I need to use dev?
Thanks,
Kristen
Comment #22
dawehnerThis is not even fixed in dev.
Comment #23
Kristen PolThanks for the update. Do you need help getting it in for D6? Let me know what I can do.
Kristen
Comment #24
MohammadMoussa-Lebanon CreditAttribution: MohammadMoussa-Lebanon commentedhello every body ,im trying to make a website for sales, but im facing a problem which is , i have 3 categories apartments (for sale , for rent , to buy ) ,lands (for sale , for rent , to buy ) , buildings (for sale , for rent , to buy ) ,
all i want to do is to place 2 select boxes and let the user select in the first box if he want apartment wo land or building and in the second box for sale or for rent or to buy and click a button which create a query and show all in the same page, i mean all results must be in the same page,please help me im a new drupal user ,its a hard problem:S:S:
thanks alot
Comment #25
AlexisWilke CreditAttribution: AlexisWilke commentedI have many similar problems right now, in 6x.3.x-dev
I suppose that options_validate() should not use the & but it was there except in two places so I re-instated it in my version. Works nice now. 8-)
Comment #26
AlexisWilke CreditAttribution: AlexisWilke commentedJust in case, I'm attaching a 3.x-dev patch.
Thank you.
Alexis Wilke
P.S. the patch below is not 100% complete, but that's a quite good start already.
Comment #27
AlexisWilke CreditAttribution: AlexisWilke commentedThis is still not resolved... and I have not gotten any good answer on whether it should be one way or the other. Maybe no one knows... 8-)
Anyway, there is me looking at the function query($get_count = FALSE) that remains. There are several still! (Most lost their parameters and for the few that did not yet lose their parameter they generally don't need it.)
So... function compile_fields() from views/plugins/views_plugin_query_default.inc around line 920:
The
if (!empty($get_count_optimized))
(last if() in the function) checks a function that's not defined.Then the following function is a query($get_count = FALSE) which actually makes use of the $get_count variable which I would imagine will always be false since no other query() function has that parameter (and will break the whole thing since the base class defines query() without parameters.)
Note that the compute_fields() is probably trying to use $this->get_count_optimized and thus the query() function should too, methink.
Shall I continue?
Comment #28
tsphethean CreditAttribution: tsphethean commentedA little sad to be patching 2.16, but came across these warnings when doing a PHP 5.4 upgrade on an old site.
I've gone through the patch from #13 and manually applied what is outstanding from the latest release. This should apply cleanly against 2.16, or I can re-roll for dev if needed. Don't know if this is likely to be committed given what has moved on, but the patch file might be useful for someone else...
Comment #29
ajayg CreditAttribution: ajayg commentedPatch applies fine, but missing two files which require similar changes
views_handler_filter.inc
views_handler_filter_date.inc
Comment #30
Gil_Gamesh CreditAttribution: Gil_Gamesh commentedSeeing this in 7.26-1 when I activate the Calendar module.
Strict warning: Declaration of views_handler_filter_user_relationships_type::value_submit() should be compatible with views_handler_filter_in_operator::value_submit($form, &$form_state) in _registry_check_code() (line 3161 of /usr/share/drupal7/includes/bootstrap.inc).
Comment #31
v8powerage CreditAttribution: v8powerage commentedThis is very bad seems views is not meant to run on new versions of php...
Comment #32
tsphethean CreditAttribution: tsphethean commentedRe-rolled the patch in #28 to add an ocurrance in views_handler_filter.inc (thanks @ajayg). I can't see any problems with views_handler_filter_date.inc
@-Shaman- - views will run on new versions of PHP, there are just a few patches that need applying. We're successfully running views on PHP 5.5 with this patch and a few others applied in our build process (using drush mask to make adding patches easy)
Comment #33
tsphethean CreditAttribution: tsphethean commentedComment #34
hass CreditAttribution: hass commentedComment #35
jackalope CreditAttribution: jackalope commentedI applied the patch in #32 to the newest version of views-6.x-2.x-dev; without the patch, the newer version results in no errors on my sites, but with the patch, there's tons of this sort of error. Does #32 actually regress the work done in the most recent dev version of the module?
Comment #36
izmeez CreditAttribution: izmeez commentedJust adding a reference to the other issue that may be related, #893128: Fix E_STRICT notices - method declaration compatibility with init(), pre_render(), _validate() and _submit() with PHP 5.4.x
Comment #37
osopolarMarking this as duplicate of #2411093: PHP strict warnings: Declaration of ... should be compatible with ..., as this issue initially was abut the init()-functions which seems that it got fixed in views 6.x-2.x. Looking at the patches seems that what is left is the PHP strict warnings problem.
Comment #38
vijaycs85Though this issue is closed, the follow up deals with 6.x-3.x and this issue is about 6.x-2.x and here is the fix for #34 on top of the patch in #32
Comment #39
apaderno