I have been attempting to update this module from v 1 to 1.1. Followed the standard procedure for modules updates. Disabled it, dropped the new version into sites/default/modules, went to update.php. This is where I first noticed that there might be a problem. At update.php, it was not listed as an available update, with the other two updates I was doing. I went ahead and ran the updates though, as there were two other updates that I needed to do.

I then Proceeded to the modules page then to enable them again. In the list of modules though, the title of og_titles was not in the list. The check boxes were there as was the description (this is how I knew it was the appropriate module). Enabled it, saved cfg, and now this appears at the top of the page:

Warning: Call-time pass-by-reference has been deprecated in /usr/home/www/tuatha.info/sites/default/modules/og_titles/og_titles.module on line 583

Warning: Call-time pass-by-reference has been deprecated in /usr/home/www/tuatha.info/sites/default/modules/og_titles/og_titles.module on line 583

This is a feature on the site that I have not implemented yet, so I did do an uninstall, made sure it was blasted from my system, and then tried to reinstall cleanly v 1.1. Same exact results, no title of the module being listed on my modules page, and same lines of error point to line 583.

If you need anymore specifics, browser, php, apache, mysql versions etc, easy to give. Anything I am able to do to assist.

I am working on two sites, which I hope to implement this module. Seems very useful, and pertinent to what these two sites will be doing.

Cheers
Murias

Comments

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Active » Needs review

The warning message was a typo by myself. I have fixed this in the dev version, but it won't update for 12 hours.

I'm not sure why the update didn't show up. I just tried this myself. If you didn't have the module enabled (installed), then it won't need an update because it will install the most recent versions itself.

murias’s picture

murias commented

thanx for such a quick response. It is great when people care about the code that they write.

I will let you know how it goes tomorrow.

Cheers
Murias

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Version: 6.x-1.1 » 6.x-1.x-dev

I found some other silly bugs, and those should also be fixed whenever the dev version updates.

murias’s picture

murias commented

Sorry it has taken me so bloody long to get back to you on this. I installed the dev version as you had suggested. Actually had done this a couple of weeks ago, just had not had the time to respond here.

I get this error now on every page after installing the dev version:

Warning: Call-time pass-by-reference has been deprecated in /usr/home/www/tuatha.info/sites/default/modules/og_titles/og_titles.module on line 600

hmmmmm.

Cheers

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented

It shouldn't effect anything, but you can update to the latest dev version. Sorry, I missed another one.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.