Posted by phpdiva on December 7, 2009 at 8:31pm
| Project: | Drupal.org CVS applications |
| Component: | Miscellaneous |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
| Issue tags: | module review |
Issue Summary
I wrote a module to fulfill a feature request for Drupal 6. See issue "Add permissions to disable RSS feeds": http://drupal.org/node/28337, specifically comment #104. The issue has been around since 2005, and seems like there is still a need for this feature in Drupal 6. The module simply adds a permissions group to "view site RSS feed" and displays rss.xml page based on that permission.I was not able to find a module that has this functionality, so I'm pretty sure this is not a duplicate. I also posted in the "Contributed Module Ideas Group": http://groups.drupal.org/node/38728.
Thanks!
Comments
#1
#2
#3
A module made of 18 lines (where just 3 lines are the effective code) cannot be considered a module.
The purpose of the CVS application is to see if the applicant understood how to write a Drupal module / theme; the proposed code doesn't allow to verify that.
Then, there isn't the need to use such module, when everybody can create a custom module, and add those code lines.
#4
Thanks!
#5
#6
This is actually something that *lots* of people would find useful since there is a big demand for this feature to be put into core. I'd like to see this maybe have more permissions (core modules that provide feeds are aggregator, blog, and node). I know it'd still be a small module, but again, this would be a useful feature until this is fixed in core. As such, I've marked phpdiva's application back to 'Pending' (and the issue here to needs work).
#7
@Dave,
Thanks for re-opening this, and yes - I was thinking the same thing. This needed more features.
Attaching the module again with the following new features:
Added support for blog (individual user feeds and main blog feed), taxonomy and aggregator RSS feeds.
This is now also hiding the RSS icon if user is not allowed to see a particular feed.
#8
This is starting to look like a better feature set.
I think the module now adresses the most common feature/support requests that pop up on Drupal.org, variations on "How do I turn off the RSS feeds for my site?"
Currently, the only UI is on the main permissions form. The module would benefit greatly from an implementation of hook_help() and good documentation.
The 'version' line needs to be removed from the .info file, as this will be handled by the Drupal.org packaging scripts, IIRC.
+1
(I'd likely use this module, if it were actively maintained in contrib.)
#9
Thanks for the feedback! Uploaded new version with these changes:
- Removed the version line from .info file
- Added hook_help() and README file
#10
Looks great!
So sorry for the delay, but your CVS application has been approved. Use it wisely and responsibly!
#11
Automatically closed -- issue fixed for 2 weeks with no activity.