This module is a blatant ripoff of the Google Base module (http://drupal.org/project/googlebase). The entire code base was copied from there. I would encourage collaboration wherever possible.

99% of what this module is trying to accomplish can be achieved by implementing 2 hooks provided by the Google Base module.

Comments

compujohnny’s picture

compujohnny commented

Hi,

I thought this was opensource code (I can use and reuse it as I see fit),

I used some of the code on the googlebase project which was a premature work at the time,

I put a lot of work into that module and made it Ubercart compatible and added a lot of fields support for Google Merchant,

I added multi picture support and totally configurable product name and description,

The database tables are totally different, than the googlebase project at the time I used its code,

I dont see that using some of the code in the googlebase project can be called a ripoff,

I just used the authentication and basic apis, but I did not want to make it a dependency because it was not even a dev release yet (Only in CVS),

I think this is the whole idea behind opensource, if u dont want people to reuse your code dont publish it,

Thank You,

jtsnow’s picture

jtsnow commented

It is open source. My problem isn't with the code being snatched away. My problem is with the lack of collaboration (which, if you were a real proponent of open source software, you would be open to). You could have easily posted an issue (with patches!) in the issue queue for the Google Base project. I support what this module is trying to accomplish and welcome it to use the API provided by the Google Base module.

BUT, in copying the code, you have over 20 functions that are doing essentially the exact same thing as the Google Base module. What if people install both modules? They have to enter their Google Base code on 2 different admin pages, their code base and database become more bloated by duplicate functionality, and there is potential for conflicts between the two modules (depending on how careful you were when renaming/refactoring things throughout the code).

Like I said, this module could be achieved by implementing 2 simple hooks provided by the Google Base module's API. I would be glad to post a patch when I have time.

compujohnny’s picture

compujohnny commented
Category: bug » feature
Status: Active » Needs review

I was on a tight schedule at the time with a client needing this module asap, and your module was still in CVS at the time,

There was no time to write patches and waiting for you to test them and commit them to your project,

And the hooks you mention were certainly not there at the time, otherwise they could've saved me a lot of time,

This module is specific to the Google Merchant (for products only), thus I am changing its name to Ubercart Google Merchant Integration,

I also believe in giving credit when its due, so I will give credit to you for the effort you made that saved me a lot of time in building this module,

However, I dont think that any reuse of code in an open source project should ever be called a rip-off,

Thank You,

compujohnny’s picture

compujohnny commented
Status: Needs review » Fixed

I have added a thank you paragraph to the module page, because as I told u I like to give credit when its due,

jtsnow’s picture

jtsnow commented

Fair enough. I apologize if 'rip-off' sounded harsh. Like I said, my main concern right now is avoiding collisions between the modules so that users of the modules have the best possible experience.

compujohnny’s picture

compujohnny commented
Title: This module is a rip-off » Conflict with Google Base Configuration

changing title to be more appropriate

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.