Since I don't know whether #558666: UX/security: Revamp text format/filter configuration will make it in (though I seriously hope so), I extracted a couple of unrelated bugfixes of that patch.

Summary of the changes:

  • Various missing variable declarations in tabledrag.js.
  • A better tableDrag.restripeTable() method, which accounts for hidden table rows and uses a much more simple logic.
  • Simplifies the user role access selection and also removes the unnecessary fieldset around those checkboxes.
  • Ensures that a hook_form_alter() implementation has access to the text format and stored filter configuration in the text format edit form.
  • Ensures that a text format name is saved without leading and trailing spaces.
  • Ensures that internal Form API values are removed from the submitted form values before a text format is saved.
  • Fixes a wrong function argument order for filter settings callback functions, so all Filter API callbacks use the same arguments.

Additionally, these changes also make sure that I'll be able to implement the new text format and filter administration interface in a contrib module, if it turns out that I will have to.

Comments

Status: Needs review » Needs work

The last submitted patch failed testing.

sun’s picture

Status: Needs work » Needs review
StatusFileSize
new10.04 KB

errrr. Wrong copy + paste, sorry.

cweagans’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me. It would be great to see #558666: UX/security: Revamp text format/filter configuration committed, but I guess this will do in the meantime :)

dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -FilterSystemRevamp

Automatically closed -- issue fixed for 2 weeks with no activity.