Range of sub-queries are not honored [#653926]

Comment	File	Size	Author
#6	range-comment.patch	669 bytes	Crell
#1	653926-range-on-subqueries.patch	2.86 KB	damien tournoud

Comment #1

damien tournoud commented 8 December 2009 at 00:47

Status:

Active

» Needs review

Status	File	Size
new	653926-range-on-subqueries.patch	2.86 KB

The good news is that all our supported database engines actually support the same syntax LIMIT $number OFFSET $offset. Let's simply use that. This patch does that, and adds an additional test for range on sub-queries.

Log in or register to post comments

Comment #2

chx commented 8 December 2009 at 15:47

Status:

Needs review

» Reviewed & tested by the community

Well, OK but I would love to see then the normal range queries use this construct too -- in another isuse of course.

Log in or register to post comments

Comment #3

Crell commented 8 December 2009 at 17:52

Makes sense, especially since drivers that need to do it differently can just override that method if they need to build the string differently. (Oracle, MS SQL, etc.) Might we want to document that the LIMIT method is not standard SQL but happens to be the method supported by most OSS databases? Just for completeness? Should be a simple comment addition.