toolbar drawer toggle is broken

Hm. Trying to fix this, I uncovered a slightly bigger problem. Under normal circumstances, you can't click on links outside a modal dialog. We have a click event on toolbar links that circumvents that restriction with a simple window.location.href = this.href. Unfortunately, that breaks down for links like the toolbar drawer toggle, that aren't intended to go anywhere. Normally for that type of link you just return false from a click event handler, and that keeps the native click event from happening. But it doesn't stop our simulated click event from happening. So when you click on the toolbar drawer toggle, you get the correct JS behavior where the drawer slides shut -- and then a second later your whole page reloads, which is decidedly not what you were expecting.

I'm attaching a patch to fix the boneheaded JS error, but the bigger problem is unsolved. We need a better way to circumvent the modal dialog for toolbar links, and I haven't dug into jQuery UI Dialog enough to know exactly what that would be.

Yes, it is. So this is good to go.