Installing Drupal 7 in non-English language doesn't pick up st() installation lists

I've attached a French .po file from profiles/default/translations that has the above strings in it and should be expressed as:

1. Choix du profil

3. Vérification des pré-requis
4. Installation de la base de données
5. Installation du profil
6. Installation des traductions
7. Installation du site
8. Finalisation des traductions
9. Fin de l'installation

I'm not sure how one would be able to choose a profile in any other language other than English, so not sure the first translation is relevant:

#: install.php:950
msgid "Choose profile"
msgstr "Choix du profil"

#: install.php:952
msgid "Verify requirements"
msgstr "Vérification des pré-requis"

#: install.php:953
msgid "Set up database"
msgstr "Installation de la base de données"

#: install.php:954
msgid "Install profile"
msgstr "Installation du profil"

#: install.php:955
msgid "Set up translations"
msgstr "Installation des traductions"

#: install.php:967
msgid "Install site"
msgstr "Installation du site"

#: install.php:987
msgid "Finish translations"
msgstr "Finalisation des traductions"

#: install.php:992
msgid "Finished"
msgstr "Fin de l'installation"

I do get strings translated when I get into the site past the install though. Just tested it again on another space to confirm this wasn't a fluke in one install.

I've been trying to test patch #3. Ran into some trouble initially because the profile directory had changed and I was trying to just use a stock v6 translation file. Using @andypost's code however I received an install error:

* Notice: Undefined index: ru_22 in locale_add_language() (line 355 of drupal-cvs/includes/locale.inc).
* Notice: Undefined index: ru_22 in locale_add_language() (line 356 of drupal-cvs/includes/locale.inc).

SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'name' cannot be null

@plach's Italian translation provided a similar error.

Is there anything else which should be included in the profile/standard/translations file?

@andypost can you try it with the recent cvs to see if it is still working for you?

Right. Renaming the file resolved the errors.

I still don't get these translations:

msgid "Choose profile"
msgstr "Выберите профиль"
msgid "Verify requirements"
msgstr "Проверка требований"
msgid "Set up database"
msgstr "Установка базы данных"
msgid "Install profile"
msgstr "Профиль установки"
msgid "Set up translations"
msgstr "Установка переводов"
msgid "Install site"
msgstr "Установка сайта"
msgid "Finish translations"
msgstr "Завершение перевода"
msgid "Finished"
msgstr "Завершено"

When doing an install with the ru.po file. This is a diff of my code from core:

Index: includes/install.inc
===================================================================
RCS file: /cvs/drupal/drupal/includes/install.inc,v
retrieving revision 1.123
diff -r1.123 install.inc
953a954,955
>         // Select default context.
>         $locale_strings = $locale_strings[''];

Adding tag

Not sure what (other than my system environment) changed, but I just set up this patch and it worked this time.

It was the first patch I applied off of a clean install, so perhaps there was some other conflict when I last tested this 2 weeks ago.

I also didn't see any warnings or errors with the install and the patch is very straight forward so I'm marking this as RTBC.

Ok, I've spent a bit too much time looking at this today.

I've been trying to both verify the success I found on another machine (and reported above), and also figure out how the patch was intended to work.

The whole header redirection in the previous function install_goto() messes up a lot of basic debugging efforts. Was forcing in values with cookies to try to pull out what was and was not working.

It kept freezing for me after the string "Drupal can use CREATE TABLE database commands."

Not sure if somewhere within the DatabaseTasks something is messing up, but at this point it seems to be beyond my ability to resolve. For those who want to critique/improve or abandon my debugging approach within the st() function:

/**
 * Functional equivalent of t(), used when some systems are not available.
 *
 * Used during the install process, when database, theme, and localization
 * system is possibly not yet available.
 *
 * @see t()
 */
function st($string, $args = array()) {
  static $locale_strings = NULL;
  global $install_state;
  
  setcookie("TestState", serialize($install_state));
  
  if (!empty($locale_strings)) {
    setcookie("TestLocaleA", serialize($locale_strings));
  }
  
  // print_r($locale_strings);

  if (!isset($locale_strings)) {
    $locale_strings = array();
    if(!empty($locale_strings)) {    
      setcookie("TestLocaleD", serialize($locale_strings));
    }
    if(!empty($locale_strings)) {    
      setcookie("TestInside1", $string);
    } else {
      setcookie("TestInside2", $string);
    }
    
    if(!empty($locale_strings)) {    
      setcookie("TestArgs1", serialize($args));
    } else {
      setcookie("TestArgs2", serialize($args));
    }
    
    if(!empty($locale_strings)) {    
      setcookie("TestState1", serialize($install_state));
    } else {
      setcookie("TestState2", serialize($install_state));
    }
    if(!empty($install_state['parameters'])) {
      print_r($install_state['parameters']);
    }
    
    if ($string != 'Drupal can use CREATE TABLE database commands.') {
      print_r($locale_strings);
      print_r($install_state);
      echo "!! RED $string !!";
    } else {
      echo "beginning <pre>";
      print_r($locale_strings);
      print_r($install_state);
      echo "</pre>  !! BLUE $string !!";
    }
    
    if (isset($install_state['parameters']['profile']) && isset($install_state['parameters']['locale'])) {
      setcookie("TestParameters", serialize($install_state['parameters']));
      $filename = 'profiles/' . $install_state['parameters']['profile'] . '/translations/' . $install_state['parameters']['locale'] . '.po';
      setcookie("TestFilename", $filename);
      if (file_exists(DRUPAL_ROOT . '/' . $filename)) {
        require_once DRUPAL_ROOT . '/includes/locale.inc';
        $file = (object) array('uri' => $filename);
        setcookie("TestFile", serialize($file));
        _locale_import_read_po('mem-store', $file);
        $locale_strings = _locale_import_one_string('mem-report');
        setcookie("TestStringsA", $locale_strings);
        // Select default context.
        $locale_strings = $locale_strings[''];
        setcookie("TestStringsB", $locale_strings);
      }
    }
  }

  require_once DRUPAL_ROOT . '/includes/theme.inc';
  // Transform arguments before inserting them
  foreach ($args as $key => $value) {
    switch ($key[0]) {
      // Escaped only
      case '@':
        $args[$key] = check_plain($value);
        break;
      // Escaped and placeholder
      case '%':
      default:
        $args[$key] = '<em>' . check_plain($value) . '</em>';
        break;
      // Pass-through
      case '!':
    }
  }
  if (!empty($locale_strings[$string])) {
    setcookie("TestLocaleB", serialize($locale_strings[$string]));
  }
  
  if (!empty($string)) {
    setcookie("TestLocaleC", serialize($string));
  }
  if (!empty($string)) {
    setcookie("TestArg", serialize($args));
  }
  return strtr((!empty($locale_strings[$string]) ? $locale_strings[$string] : $string), $args);
}

It did in one instance

#11 It worked fine in my tests (in a new install)

#14 it didn't (although for the life of me I couldn't say why other than it was a different computer)

In trying to debug this I got lost. Code was not allowing me to access (either by echo or cookie) the values being set.

Someone else needs to look at this before it's considered fixed.

I just tested this again. After selecting the Italian I wasn't able to get it to display in the installation. I was using the minimal profile with a profiles/minimal/translations/it.po file with related strings:

 885 #: install.php:954
 886 msgid "Install profile"
 887 msgstr "Profilo d'installazione"
 888 
 889 #: install.php:955
 890 msgid "Set up translations"
 891 msgstr "Imposta traduzioni"
 892 
 893 #: install.php:967
 894 msgid "Install site"
 895 msgstr "Installa il sito"
 896 
 897 #: install.php:987
 898 msgid "Finish translations"
 899 msgstr "Completa traduzioni"
 900 
 901 #: install.php:992
 902 msgid "Finished"
 903 msgstr "Finito"
 904 
 905 #: install.php:1009
 906 msgid "To configure your website, please provide the following information."
 907 msgstr "Per configurare il sito, inserisci le seguenti informazioni."
 908 
 909 #: install.php:1025
 910 msgid "Site e-mail address"
 911 msgstr "Indirizzo e-mail del sito"

Hopes this helps to clarify that this is still a problem (with or without the patch).