Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Getting a couple php notices around the constants defined in apachesolr.module and the constant REQUIREMENT_ERROR.
The notices from apachesolr.module are because quotes arn't used in the define(). PHP examples show you that it should use quotes, but PHP is nice, and assumes you meant to use them.
For REQUIREMENT_ERROR, that is defined in install.inc in both 6 and 7. (http://api.drupal.org/api/constant/REQUIREMENT_ERROR). So you have to include it here to use that constant.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | requirement_error.patch | 827 bytes | robertdouglass |
| #6 | notices-655006-6x-1x-6.patch | 1.54 KB | pwolanin |
| #5 | notices-655006-6x-1x.patch | 1.46 KB | pwolanin |
| apachesolr_constants.patch | 1.54 KB | Scott Reynolds |
Comments
Comment #1
Scott Reynolds commentedSS: http://skitch.com/supermanscott/nk4n7/apache-solr-scotts-contrib
Comment #2
robertdouglass commentedI applied this to 6.1 and 6.2, thanks. My question as a followup is whether we want to move REQUIREMENT_ERROR into apachesolr.module so that we don't have to include the install file?
Comment #3
robertdouglass commentedCrap - used the wrong message in the cvs commits.
Comment #4
Scott Reynolds commentedThats a interesting question. The only place I could think of where both install.inc and apachesolr.module would be include is admin/reports/status.
Do things blow up there?
Comment #5
pwolanin commentedhow about this for 1.x? seems to work fine.
Comment #6
pwolanin commentedoops - didn't see that Robert already applied the 1st part. Applying this patch.
Comment #7
pwolanin commentedremaining fix + CHANGELOG entry to be ported
Comment #8
robertdouglass commentedPeter, looks like you missed removing the include. Applying attached to clean up, and then syncing 6.2. to be the same.
Comment #9
pwolanin commentedthanks for catching that
Comment #10
claudiu.cristeaPorted to DRUPAL-5--2 in: #317968 and #317974.