There is an issue with all three images showing when "Three State" is enabled. Rollover just shows no image at all. You can even see it in the signwriter config page (admin/settings/signwriter). This happens on IE, FF, and Chrome. Happens on multiple servers (one Fedora 9 and the other Ubuntu Server 8.10) using the GD2 image lib.

Check out the attached screenshots for an example and my config.

CommentFileSizeAuthor
#4 threestate2.patch1.66 KBkndr
#1 threestate.patch1.64 KBkndr
2009-12-09_144238.png352.92 KBchadhester
2009-12-09_144101.png24.67 KBchadhester

Comments

kndr’s picture

kndr
he/him
Primary language Polish
Location Rybnik, Poland
commented
Version: 6.x-2.0-beta1 » 6.x-2.x-dev
Component: User interface » Code
Priority: Normal » Critical
Status: Active » Needs review
StatusFileSize
new threestate.patch1.64 KB

Try this patch. In my opinion, code inside signwriter.js was unfinished.

kasha_x’s picture

kasha_x commented

So in addition to learning how to patch a module I got the three states working. Thanks kndr :-)

kasha_x’s picture

kasha_x commented

It's failing in Firefox 2.0 and lower, but works fine in the 3.x branch. I love this module enough to put a javascript alert for all incompatible browsers, however it would be nice if it worked in Firefox 2.0 because that browser is not very old and I'm sure many people use it.

kndr’s picture

kndr
he/him
Primary language Polish
Location Rybnik, Poland
commented
StatusFileSize
new threestate2.patch1.66 KB

Hm. Thanks for testing this patch in old browsers :) If I know, Firefox 2.x is used by less than 2% users. Is it significant value? Anyway, I've attached new patch.

kasha_x’s picture

kasha_x commented

ok, patched up the module with threestate2.patch and uploaded it. Then Opera stopped working! Shows nothing on hover. So I rolled it back to threestate.patch. I hope you're enjoying this :-) My partner says coding is 'relaxing'. I'd be going mad right about now!

kndr’s picture

kndr
he/him
Primary language Polish
Location Rybnik, Poland
commented

What version of jQuery have you got in Drupal? Everything works fine in my Opera (ver.9 and ver.10) but I've installed jQueryUpdate 1.3.2. Maybe it makes the difference?

kasha_x’s picture

kasha_x commented

Haven't gotten back to you yet because I have to wait for my partner to patch up the module on his unix system (I'm having problems) to test it again.

Like you said before, Firefox 2 is not really used so I'm using the first patch for now. Thanks for helping us out on this :-)

marcoka’s picture

marcoka commented

the intention was to show the images in the profile preview?(only one and the states on hover and not all 3 images?) used both patches. didn´t not change something. (cleared cache via devel and cleared signwriter cache).
maybe i misunderstood?

kndr’s picture

kndr
he/him
Primary language Polish
Location Rybnik, Poland
commented

Intention was to fix the bug ;) Profile page wasn't the problem. Simply, three state didn't work in menu blocks - "Rollover just shows no image at all". I am succesfully using #4 on two sites.

goto10’s picture

goto10 commented

Neither of these patches is working for me. any thoughts? Am i missing something I could fix with some CSS or something?

Thanks!

-Jesse

jonesui’s picture

jonesui commented
Status: Needs review » Active

I am having the same issue with 6.x-2.x-dev.
Patch did not solve problem.
Installed jQueryUpdate 1.3.2 but problem persists.

ipsitamishra’s picture

ipsitamishra commented

This problem still persists.

For me, with 6.x-2.x-dev verison the problem is occuring. I applied both path as mentione din comment 1 & 4. Non of them worked for me!!

Even though I enable three state, in signwriter config page (admin/settings/signwriter) I don't see an image showing the 2 states.

I upgraded jquery_update to 1.3.2 too. Still no luck.

Then I upgraded signwriter module form 6.x-2.x-dev to 6.x-2.0-beta2 version.

So it seems this issue exists in beta2 version too.

(More information: I am using Ubuntu server, GD2 library, FF 3.0.19 & Opera 10.60 (not working in both browsers) )

Would request to those who have got a solution for thsi problem, to outline the STEPS they followed to solve this.

Thanks,
Ipsita

sander-martijn’s picture

sander-martijn commented

This is still a problem, both with 6.x-2.x-dev and 6.x-2.0-beta2. I've tried both patches and neither solve it. All states are same font size, how bad the offset is on the first menu item depends on the chosen font size. I'm considering switching to cufon but would rather stick to signwriter.

curious why this issue seems to have been forgotten about