Posted by David_Rothstein on December 9, 2009 at 8:24pm
4 followers
Jump to:
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | overlay.module |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
This bug is easy to see if you use contextual links (for example to configure a block and move it from the left to right sidebar), or via straight up editing of a node.
When you submit the form, the overlay closes, and the parent window that you see underneath does not reflect the changes you made. Only if you reload the page manually do you see the changes.
The attached patch fixes it - note that all we have to do is remove some code! Discussed with @ksenzee and we both agreed that whatever benefit that code had in avoiding unnecessary redirects (I can't even find any at the moment?) is almost certainly overshadowed by this bug, so let's just remove it.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| overlay-reload-parent-window.patch | 2.69 KB | Idle | Passed on all environments. | View details |
Comments
#1
Should clarify this... this patch only addresses the case where the overlay closes automatically on form submission. It does not address the case where you edit some stuff in the overlay, submit some forms which do not cause the overlay to automatically close, and then close the overlay manually. That one is a trickier bug which I will file as a separate issue a bit later.
#2
See #655722: Changes made in an overlay session are not reflected when the user closes the overlay for the other issue.
#3
This is a very straightforward change that I probably should have made before the initial commit.
#4
Nice. I always love less buggy code that also results in less code. ;)
Committed to HEAD!
#5
Automatically closed -- issue fixed for 2 weeks with no activity.