Posted by c960657 on December 10, 2009 at 8:27pm
5 followers
| Project: | Drupal core |
| Version: | 8.x-dev |
| Component: | base system |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
| Issue tags: | API clean-up, Favorite-of-Dries |
Issue Summary
theme_menu_link() and drupal_pre_render_link() use the #href array key to specify a Drupal path that is passed as the second parameter for l($text, $path, $options).
Most places in core use the term “path” when referring to internal paths. I suggest renaming #href to #path.
drupal_pre_render_link() was added in #602522: Links in renderable arrays and forms (e.g. "Operations") are not alterable and theme_menu_link() in #283723: Make menu_tree_output() return renderable output.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| href-path-1.patch | 32.63 KB | Idle | Passed on all environments. | View details | Re-test |
Comments
#1
Reroll.
#2
That makes a ton of sense, IMO. Let's see what the tests say.
#3
subscribing. Not sure how this fits in the "no API/interface changes" period we're kind-of in.
#4
Yes, it makes a ton of sense, but 1) it's 2-3 months past API clean-up freeze 2) breaks already ported modules and 3) we have a lot more pressing issues in the queue. If this would've been ready during slush, I would have RTBC'ed it immediately.
#5
#6
#7
#8
The last submitted patch, href-path-6.patch, failed testing.
#9