Rename #href to #path

That makes a ton of sense, IMO. Let's see what the tests say.

subscribing. Not sure how this fits in the "no API/interface changes" period we're kind-of in.

Yes, it makes a ton of sense, but 1) it's 2-3 months past API clean-up freeze 2) breaks already ported modules and 3) we have a lot more pressing issues in the queue. If this would've been ready during slush, I would have RTBC'ed it immediately.

Rerolled #9.

Rerolled #10.

The migration of the email field into core introduced a new call to theme_menu_link().

#13: href-path-656614-13.patch queued for re-testing.

Just a global search/replace.

Missed a couple bits in link.module

Patch path-656614-18.patch re-rolled for 8.x
The patch applies cleanly at commit c75929755f2e0ad474db48a4ac580bc5b92f8c59

Patch from #19 contains wrong merge conflict marks... Back to patch #18 then!

Started with a new global search and replace.
And added link.module changes.

Unsure if i did replace too much. Let's see mr. bot! :-)

22: 656614_link_href_path_22.patch queued for re-testing.

Reroll and apply replacement pattern to new matches for #href.

25: 656614_link_href_path_25.patch queued for re-testing.

Trying a reroll. Some conversions are already in...

Rerolling.
Not that many #href remaining now that we have #route_name references, too.
Possibly there are some #path instances that should be converted to #route_name, too?
Guess there are still the same fails as before?

Rerolling and fixing. :-)

Dropping old attachments.

Nice. The previous failing are gone. Now all others fail.
So currently we need both (new) #path and (old) #href support on drupal_pre_render_link().

Forgot the interdiff.

+++ b/core/includes/common.inc
@@ -2949,6 +2949,9 @@ function drupal_pre_render_link($element) {
   else {
     $element['#markup'] = l($element['#title'], $element['#href'], $element['#options']);
   }

Why would we keep this legacy support?

Patch at #30 switches away from #href to #path with the resulting 19 fails.
I didn't see how to fix those. Looks like the link field provides still #href instead of #path... Thought this might be by intention as an explicit href attribute.

Not sure if we even need all this conversion after the #route_name introduction.

While many of the #href/#path will be replaced with #route_name, we still need it for external links.

Patch rerolled

Found 2 more occurances

reroll

reroll attached

Read through the patch, I dont see anything wrong with this. :)

I think this will conflict with #2277103: Switch Drupal::l() and LinkGenerator to expect a Url object, let's make sure that goes in first (since its a beta blocker).

@277103 is marked as fixed, here is a reroll

@alexpott pushed a commit that stopped theis from applying, another reroll.

Well, actually #2347465: Convert all instances of #type link/links to convert to use routes should kill all instances of #href, sorry.

Also, any case using #href would refer to a URI, not a path, so I think this should be closed.

Yeah, thank you for your work on this issue though!