This may seem to be stupid and trivial.. --i am picky, that's not really a good thing--

The link in the help text or description on the node_gallery access settings page is displaying as:
<a href="/admin/whatever/rebuild">rebuild all permissions</a>
But it should display as as a link rebuild all permissions

The only reason I can see is in the '#description' => t(... @@ line 36 %rebuild -vs- !rebuild

excuse my patch, I have to figure out cvs... someday...

CommentFileSizeAuthor
node_gallery_access.admin_.inc_.patch1.11 KBdbeall

Comments

dbeall’s picture

dbeall commented
Status: Active » Needs review
justintime’s picture

justintime commented
Assigned: Unassigned » justintime
Status: Needs review » Fixed

@dbeall, thanks for the patch, but you motivated me to fix the real problem. There was even a TODO comment in there to prompt the user using node_access_needs_rebuild() when they changed a variable that triggers a rebuild. Not only when settings are changed do we need to trigger this, but we also need to do it when NGA is enabled and disabled.

While I was in there, I saw that the text output for the default location of ng_access_pass_gallery and ng_access_pass_image wasn't working, so I fixed that too.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.