Mainly the bank driver, which were migrated from boletophp doesn't fit to Drupal Coding standards.

Some functions need a little rewrite too.

Comments

lourenzo’s picture

lourenzo commented
Status: Active » Needs work
wundo’s picture

wundo commented
Assigned: Unassigned » wundo

I'm willing to work on it, but I think we should break this issue into several others. (And use this one to keep track from the progress)

cheers,
Fabiano Sant'Ana

lourenzo’s picture

lourenzo commented

Nice :)

I just granted you access to the CVS.

I agree this could be broken into other issues, and I already made all files pass on coder, just not using the drupal_substr and drupal_strlen because the files are language-specific and we don't need the extra footprint of testing for multibyte and stuff.

FranciscoLuz’s picture

FranciscoLuz commented

I have made available a new library for Boletophp at https://github.com/drupalista-br/Boleto/wiki/Projeto-Boletophp-API

The code has been completely re-written from ground up. You guys might consider migrating it into UC Boleto module.

Cheers,

rfsbsb’s picture

rfsbsb
Primary language Portuguese, Brazil
Location Kitchener
commented
Status: Needs work » Closed (duplicate)

This issue is duplicated see #1203372: Nova versao da Biblioteca Boletophp