notice: Undefined variable: title in /public_html/dev/sites/all/modules/views_attach/views-attach-display-node-content-view.tpl.php on line 30.

The above showing in my sandbox logs for the latest 11-18-09 -dev tarball

CommentFileSizeAuthor
#4 va_theme.patch1.44 KBfgm
#3 656814.patch645 bytesswentel

Comments

vm’s picture

Status: Active » Closed (duplicate)
WorldFallz’s picture

Title: notice: Undefined variable: » notice: Undefined variable: title
Status: Closed (duplicate) » Active

Sorry VM, I don't think this is a dupe of that issue-- i'm getting this exact error on a fresh d6 dev without views_gallery.

Not sure of the cause yet, but I can confirm that, for whatever reason, a dsm() shows that $title is in fact not defined in views-attach-display-node-content-view.tpl.php. Changing line 30 to <?php if (isset($title)): ?> gets rid of the error, but I'm not sure I'd call that a "fix"-- at least until one of the maintainers takes a look and verifies this is by design.

I working with the current dev of views3-- which version of views are you using?

swentel’s picture

Status: Active » Needs review
StatusFileSize
new645 bytes

Confirmed - attached patch fixes that - nicer solution todo this in theme function instead of template.

fgm’s picture

Title: notice: Undefined variable: title » notice: Undefined variable: title + duplicate code
StatusFileSize
new1.44 KB

Figured I'd do some refactoring: no need for two identical functions, it seems.

fgm’s picture

Status: Needs review » Reviewed & tested by the community

Tested (on D6.17-dev, PHP5.3), read, and looks just fine to me. Plus, coder.module has nothing to say on that specific file.

Crell’s picture

Status: Reviewed & tested by the community » Fixed

Thanks guys! Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.