There's the potential that using CTools could cut the amount of code in the Contact Importer module by possibly 20%. And that 20% is the tricky stuff. See
http://zroger.com/node/30
http://www.chapterthree.com/blog/josh_koenig/ajaxmodal_functionality_0_l...
The trick will be that our modal form is multi-step.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | contact_importer_automodal.patch | 4.8 KB | jcmarco |
Comments
Comment #1
hadsie commentedI believe that modalfram api (http://drupal.org/project/modalframe) is now in drupal 7 core, so perhaps that's what should be used for popups?
Comment #2
zroger commentedHave a look at Dialog API. It's all the goodness of CTools modals, but uses jQuery UI dialogs. Its actually based on the work I wrote up in the blog post mentioned in the first post.
FWIW, XML Sitemap just integrated Dialog (#661780: AJAX-ify the type settings on admin/settings/xmlsitemap) and there is an issue in Skinr to use Dialog (#690862: Use Dialog API module instead of Modalframe/Overlay).
Comment #3
dave reidmodalframe is more like the Overlay in D7. If you want lighter popups, I'd probably recommend the Dialog API.
Comment #4
hadsie commentedI think actually a lighter weight popup may not make as much sense for this module as the modalframe api. Modalframe adds an iframe to the page to render the window in which I think makes a bit more sense when you're rendering new forms in the popups (as contact importer does). Also, it's possible that at some point there would be multi-step forms in there, depending on the providers needs.
Comment #5
jcmarco commentedThis patch add modalframe API support through automodal module.
Automodal allows adding modalframe to modules in the same way than popup.
The patch for now only use the modalframe if there is no lightbox2 installed.
Probably the best it would be to add an admin option to select one of them.
Comment #6
jcmarco commentedComment #7
dalinPhewpf!
Took forever just to get AutoModal running.
@jcmarco your patch was good, it just needed some refinement for making things admin selectable. And try as I might I couldn't get the "oh no something went wrong, do you want to try a different provider" to work for automodal. See contact_importer_form_url() for my crufty workaround. Committed to the 2.x branch.
Try it out and let me know if it works for you.
@jmarco would you like to be a co-maintainer of the module?
Comment #8
Michsk commentedi would vote for modalframe OR ctools, but modalframe slightly more. Dialog is not good atm in my eyes. to many problems and not enough work beeing put in it.
Comment #9
dalin@Iasac please test the modalframe integration in 6.x-2.x-dev
Comment #10
dalinErrr, this should be set as "needs review".
Comment #11
Michsk commentedWill do, only thing is that i don't use this module itself. Just found it, and alltough it is a drupal diamont i don't need it in my recent project. BUT i will test it.
Comment #12
Michsk commentedagainst what is this patch made?
when i do it against the 6.x-2.x-dev of 2010-Sep-15.
Comment #13
dalinYeah sorry, it seemed too complicated to maintain a giant patch file and then have no one test it. I committed the code to 6.x-2.x-dev in the hopes of having someone actually test the code. I find that with contrib modules no one ever tests patch files, but they will test development versions.
Comment #14
Michsk commentedaha ok i will test the dev.
Comment #15
Michsk commentedOctazen has been purchased by facebook, http://octazen.com/ http://techcrunch.com/2010/02/19/octazen-what-the-heck-did-facebook-just...
Comment #16
dalinIneresting.
The odd part is that the Octazen code isn't particularly high quality - I'd say the OpenInviter library is much better written.
Comment #17
Michsk commentedOk, but i guess the octazen refering link on the project page will have to be removed, since it is not possible anymore to download it. And i don't see facebook buying a opensource company for the fact that it's open and the contributors probably would leave. If facebook would buy drupal for 100mil and you wouldnt get a piece of the pie, would you still be as active as you are now?
But back to this, i will test this tomorrow, time for sleep now.
Comment #18
dalinLets keep each issue in its own ticket. There's already lots of discussion about what to do with Octazen over here:
#784210: Octazen Engine no longer available - Make note for new installers
Comment #19
Michsk commentedi dont know if this is a strange question, but why would one install contact_importer when OpenInviter has also a drupal module?
Comment #20
Michsk commentedIm sorry i am not able to help you with testing this, i am not going to use this module, atleast for the next 6months, but it's giving me quite the hassle.
1) Unable to run postinstall.php evne with 265MB
2) I guess this is because of 1, i dont see a list of providers. So im unable to select one.
Comment #21
Michsk commented1) i have no SSH atm.
Comment #22
dalinIf you install the module packaged with OpenInviter you'll see why Contact Importer exists. The packaged module is completely useless.
Where in the process does postinstall.php fail? It doesn't really do much other than
- check if the required PHP extensions are installed
- check if it can connect to the outside world
- check if there are any updates to the library
SSH is not required, you can run postinstall.php from your broswer.
Comment #23
jcmarco commentedFinally I could test the new dev release and it works fine with the modalframe API through automodal.
Thank you.
Comment #24
dalinReleased a new version with the code. Hopefully for D7 we'll be able to use something that doesn't have 17 dependencies.
Comment #26
shantanu1 commentedFirst install ctool module (Drupal 7)
Using ctool show user detail in popup...Here is the code...