Closed (fixed)
Project:
Cleanr
Version:
6.x-0.7
Component:
User interface
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
11 Dec 2009 at 23:00 UTC
Updated:
14 Mar 2011 at 00:01 UTC
I didn't think that most themes did this, but it appears that yours might attempt to restyle the admin menu a bit.
The new dev version actually moves the "Create content" item into a new list. This, along with the fact that I personally use "Quiz" and "Ubercart", means that the top admin menu bar is looking a bit crowded.
Any option of leaving the admin menu font size as-is, or adding an option for this? I can't claim to speak for everyone, but I was a fan of the small, clean size of the original bar (a la Garland and Acquia Marina).
Thanks again for the badass theme!
| Comment | File | Size | Author |
|---|---|---|---|
| Admin menu in Garland | 88.51 KB | patcon | |
| Admin menu in Cleanr | 118.4 KB | patcon |
Comments
Comment #1
patcon commentedOh hey, accidentally didn't have new toolbar style enabled when I took that screenshot. Enabling it did break the format. I think it has to do with the new Find content button that's suppose to be aligned on the right... It doesn't seem to like being pushed onto a new line.
Comment #2
ivansf commentedI think I will have to leave it as optional.
I will see if it's possible to put a checkbox on the theme config.
Comment #3
vikingew commentedSorry if I chip in with a question here that might not be about the issue as such, but I see in the screen shots the 'Create Content' menu item in the most left position of admin_menu. In my version of a_m 6.x-3.x-dev (2010-Mar-13) I cannot find it at all and no setting to make it appear, so is this a issue with cleanr (6.x.07) or a_m?
Drupal is 6.16
Comment #4
patcon commentedI think that's an issue with admin menu itself, but you can check easily enough by switching to garland for a second
Comment #5
vikingew commented@patcon: So what version of admin menu are you using? Looking at the screen shot on the project page it doesn't show the 'Create Content' item so either it may been removed or you have styled/hacked your to show it?
btw switching over to Garland I now noticed what this issue is about and must say that I prefere the "fatter" menu in cleanr, but I also realise not everybody have a 24inch monitor so +1 to making it optional in some way.
Comment #6
vikingew commentedahh found it's been removed from admin menu http://drupal.org/node/502500 sorry for the noice here but it might interest someone passing by ;-)
Comment #7
vikingew commentedOk back again ;-) but now with a real issue involving admin_menu and as it basically concerns the same thing (in Cleanr) so I bring it up here. Admin menu now have a sub module "Administration menu Toolbar style" which basically do what Cleaner does, a bit more hight and "better" styled, with a nicely faded shadow at the lower edge. However, in cleanr this doesn't come out good at all as it appear to enforce it's own style on top of what already been styled ny admin_menu, making it look "cut off" in a strange way.
I think this new "tool bar" in admin menu is something one definately want so I think cleanr as an admin theme also should handle it "properly", which I think more or less mean to discard clenr's styling of yje menu as it doesn't really add anything of value any longer. So basically the options would be cleanr + (admin_menu + cleanr_toolbar_style) OR cleanr + (admin_menu + admin_menu_toolbar_style).
As it's purely cosmetic and doesn't affect any functionallity I haven't actually looked at any code of this yet but just approach it from a visual view point. So just bringing it up and once I fire up my php editor I may do some testing, if time allow.
Comment #8
mcrittenden commentedIssues should be active unless there's already a patch attached.
Comment #9
wiifmAgree with @yettyn, Cleanr should not style another module's output unless it horribly breaks it making it unusable.
Have removed all admin_menu specific styling from Cleanr. If users still wish to have the friendlier looking admin_menu, they can:
The module 'admin_menu_toolbar' is a part of the 3.x version of admin_menu and provides the rounded corners etc that Cleanr used it.
Committed
http://drupalcode.org/project/cleanr.git/commit/90d1317608df9676e3ccb8b0...