If the Drupal admin turns off the Node module -- on our test site this is at:

http://sandbox.oc-tech.org/admin/modules

Then you try to go to the home page of your Drupal Site, citizenspeak is causing a crash of Drupal. Now, this is probably not a big deal -- who would want to disable the node module? But still, this is bound to affect some Drupal users as long as Drupal lets people uncheck the node module. The error is:

Fatal error: Call to undefined function: node_load() in /home/.jamocha/odb/sandbox.oc-tech.org/modules/citizenspeak/citizenspeak.module on line 64

I believe there needs to be a test that the node module is enabled before node_load is called, or something like that. Other Drupal modules seem to work even if the node module is disabled, so it makes sense to apply this fix to Citizenspeak.

-rich

Comments

venkat-rk’s picture

venkat-rk commented

Is there any reason anyone would turn off node module? Everything in a drupal site is built on the node concept and indeed, Citizenspeak is itself a node type, so no wonder you are getting a php error.

oc@drupal.org’s picture

oc@drupal.org commented

I am assuming that most modules are ok with turning the node module off for a reason, and the reason is of course not that you would actually want to turn the node module off. The reason is that in a complex piece of code some things are usually initiated in a certain order and that the Citizenspeak module might be a bit nonstandard in this (minor) respect. So as part of code cleanup it might make sense, from the programmer's standpoint, to ensure that citizenspeak handles things like other Drupal modules. Not doing this is likely to have some side effects beyond what I have described. I think that George might be able to judge what those impacts might be as he knows more of the internals of Drupal than I do.

georgehotelling’s picture

georgehotelling commented
Status: Active » Closed (won't fix)

That line of code should only get called if you navigate to /node/#### so I think it's safe to assume you have the node module loaded.