The MERCI base module adds the following menu items:

Administer
* Site configurationn
* * MERCI (admin/settings/merci)
* MERCI Reservations (admin/merci/reservations/today)
* Inventory (admin/merci/inventory)

With Administration Menu 6.x-3.x-dev (or 3.0-beta3) it's even worse: at the top level there's
* By User (admin/merci/reservations/byuser)
* MERCI Reservations (admin/merci/reservations/today)
* Inventory (admin/merci/inventory)

admin/settings/merci is the only one located in the proper place. The others don't belong under admin.

admin/merci/reservations/byuser is the worst. It merges with the admin tabs (admin and admin/by-user, see screenshot)!

End-user pages should not be under admin.

Module names (especially acronyms) shouldn't appear on end user pages. I'd suggest to create a top-level "Reservations" menu item that points to merci (not admin/merci!) and to put everything else under there. The default item could well be "Today" (the tab ought to be labeled "Today"). Admins can then add additional custom views under there as they like.

CommentFileSizeAuthor
#5 manage_merci.png14.34 KBkreynen
Untitled.png11.21 KBsalvis

Comments

kreynen’s picture

Assigned: Unassigned » kreynen

These Views are new and came from locations using MERCI who had generated their own Views. I will clean this up in the next release which should be by the end of the week.

kreynen’s picture

Assigned: kreynen » johnthatcherjr

After seeing #663200, I'm pushing this back to John and Darrick to resolve. I think that entire View is going to need to be rewritten and displayed from within the module.

superlou’s picture

Just a bump. Would like to see this resolved.

kreynen’s picture

Should have a commit-able version in done tomorrow morning. Thought I was going to finish these changes today, but the day didn't go as planned.

kreynen’s picture

Assigned: johnthatcherjr » kreynen
StatusFileSize
new14.34 KB

This is taking longer than I thought. The direction I'm headed right now is creating a new permission, 'manage MERCI', and define a new admin level menu options that only require the manage MERCI permission. The pages and pathes in the current Views are stripped down to functional views that are called form the module menus.

Any thoughts on this approach?

  // Adds Manage Equipment to Admin Interface
  $items['admin/merci/manage'] = array(
    'title' => 'Manage Equipment',
    'description' => 'Manage Equipment Reservations, Checkout and Inventory (MERCI)',
    'position' => 'right',
    'page callback' => 'system_admin_menu_block_page',
    'access arguments' => array('manage MERCI'),
    'file' => 'system.admin.inc',
    'file path' => drupal_get_path('module', 'system'),
    'weight' => -19,
  );
  
  $items['admin/merci/manage/default'] = array(
    'title' => 'Overview',
    'description' => 'Dashboard of options to Manage MERCI',
    'page arguments' => array(2),
    'page callback' => 'merci_manage',
    'access arguments' => array('manage MERCI'),
    'type' => MENU_NORMAL_ITEM,
  );
  
  $items['admin/merci/manage/reservations'] = array(
    'title' => 'Manage Reservations',
    'description' => 'Dashboard of options to Manage MERCI',
    'page arguments' => array(3),
    'page callback' => 'merci_manage_reservations',
    'access arguments' => array('manage MERCI'),
    'type' => MENU_LOCAL_TASK,
  );
  
  $items['admin/merci/manage/inventory'] = array(
    'title' => 'Manage Inventory',
    'description' => 'Dashboard of options to Manage MERCI',
    'page arguments' => array(3),
    'page callback' => 'merci_manage_inventory',
    'access arguments' => array('manage MERCI'),
    'type' => MENU_LOCAL_TASK,
  );
salvis’s picture

I'd prefer to see it under admin/content/merci/* (no need for 'manage')

Thanks for working on it!

kreynen’s picture

Version: 6.x-1.1 » 6.x-2.0-beta1
Status: Active » Fixed

In the 2.x branch, there is a manage MERCI permission designed for staff

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.