If we implement hook_content_extra_fields(), we can allow users of CCK to be able to re-order the CAPTCHA field on node forms. Handy!

CommentFileSizeAuthor
#2 658366-mollom-cck-field-D6.patch934 bytesdave reid
#1 658366-mollom-cck-field-D6.patch819 bytesdave reid
#1 screenshot_011.png42.23 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new screenshot_011.png42.23 KB
new 658366-mollom-cck-field-D6.patch819 bytes

Patch attached for review with a screenshot of how it looks on the CCK 'Manage Fields' interface.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 658366-mollom-cck-field-D6.patch934 bytes

Revised patch with a much lower weight so it should sink to the bottom on the CCK UI.

dries’s picture

dries commented

This looks great. Before we commit this, let's add some extra documentation to specify _where_ the hook comes from and _why_ it is implemented. Let's also specify why we set the weight to 99999. Otherwise RTBC.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community

Actually, this is a common hook for D6 and known to developers, and we inject the element to the end of the form in mollom_form_alter(), so I think this patch is perfectly fine.

Needs to be forward-ported. Not sure how it's called in D7 though.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

We do basically the same thing with hook_field_extra_fields() in D7, but there is a critical bug since re-ordering fields in the interface doesn't actually do anything: #672794: Re-ordering fields does not take affect in forms.

dries’s picture

dries commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Reviewed & tested by the community » Needs work

I added some extra documentation and committed the patch to DRUPAL-6--1. The patch still needs to go into CVS HEAD for Mollom 7, so I've update the issue accordingly. Thanks Dave.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Fixed

Committed the same thing to the D7 branch adjusted 'CCK' to 'Field UI'.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit cd03dfb on master, fai6, 8.x-2.x, fbajs, actions by Dave Reid: 
    Patch #658366 by Dave Reid, Dries: Allow Field UI users to be able to re...

  • Commit cd03dfb on master, fai6, 8.x-2.x, fbajs, actions by Dave Reid: 
    Patch #658366 by Dave Reid, Dries: Allow Field UI users to be able to re...