In the cart page, I had removed a booking and noticed that the upgrade and addon product listed there did not have a remove box to click.

CommentFileSizeAuthor
bugreport.jpg226.98 KBweblance

Comments

willvincent’s picture

willvincent commented
Title: upgrade and addon does not have remove product box. » Removing a booking item from cart should automatically remove all the associated addon items
Component: User interface » Code

They are not supposed to.

Since they can be applied to specific dates, and what is listed in the cart does not necessarily reflect that, a simple remove this item checkbox would not work for these. They are child elements of the booking item, essentially "attributes".

They can be removed by using the "Edit Upgrade/Addon Items" link in the booking details pane, or by clicking on their names either in the cart or booking details pane, either of these links back to the addons page, where quantities can be adjusted.

However, it appears there might still be a bug you're reporting here...

Removing the parent booking item should automatically remove all the associated addon items..

I noticed this last week as well, but it only happened one time and then I wasn't able to repeat it. I'll take another look at the remove functions and see if I can't figure out the issue.

willvincent’s picture

willvincent commented
Priority: Normal » Minor
Status: Active » Postponed (maintainer needs more info)
weblance’s picture

weblance commented

FYI: I am not able to reproduce this error. I have done this 7-8 times now.

willvincent’s picture

willvincent commented

That was my experience with it as well.

I'll leave the issue status as is and look into it more in the future. I have an idea of how I might be able to modify the deletion code to better prevent this.
But, it seems to be a fluke that is extremely unlikely to occur

weblance’s picture

weblance commented

Ok, so I am able to reproduce this now with some regularity.

However, I can only help to narrow down the possibilities for you. I don't know which of these circumstances is the cause, I just know that I get the bug when I do the following:

4 or more distinct reservations for one day or more in cart
1 add-on purchased for all days of reservation
reservations sits in cart for more than a day without being checked out
delete all reservations

hope there is something there that helps.