The new dev breaks the registration page when no address is required on registration. The attached patch fixes the problem.

CommentFileSizeAuthor
uc_addresses.module.patch1.12 KBDrakeRemory

Comments

freixas’s picture

Assigned: Unassigned » freixas
Status: Needs review » Fixed

Hi,

I usually apply patches by hand so I can make sure I understand the changes. Your patch has two "chunks". I can't see any difference in the first chunk (maybe just white space changes?).

I didn't understand the second chunk, but then the light dawned. Your fix isn't right. The 'insert' op shouldn't be used during registration and therefore shouldn't need to be fixed. The problem is that 'register' case doesn't return if registration is disabled and so falls through to the next case. So all I really need to do is add a 'return' to the 'register' case.

Thanks for finding this! Look for a fix in the next dev release dated 12-13-2009 or later (although it's easy enough to patch yourself —or just keep your existing patch for now).

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.