flag_update_export() is missing from flag_export_flags() resulting with flags that are exported without api_version => which makes them disabled => which messes up with Features => causing a WSOD.

CommentFileSizeAuthor
#1 flag_export_version.patch537 bytesquicksketch
update-flag-export-1.patch741 bytesamitaibu

Comments

quicksketch’s picture

quicksketch
he/him
commented
Title: Update flag on flag export » Set the Flag API version on Export (Impossible to use exported flags in modules)
Priority: Critical » Normal
Status: Needs review » Fixed
StatusFileSize
new flag_export_version.patch537 bytes

Thanks Amitaibu, though running the update function on the flag probably isn't want we want. Instead I just set $flag->api_version = FLAG_API_VERSION; manually.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

I think that passing through the uodate function is a better - as it centralizes all the actions that should be taken before exporting a flag.

quicksketch’s picture

quicksketch
he/him
commented

The update function is intended to migrate 1.x flags to 2.x. When exporting, the flags should already be in the 2.x format. Even though the update function sets the API version too, it's only done so that Flag can discern that the flag has passed through the update.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.