Download & Extend
Flag » Issues

Set the Flag API version on Export (Impossible to use exported flags in modules)

Posted by Amitaibu on December 14, 2009 at 7:42am
Project:Flag
Version:6.x-2.x-dev
Component:Flag core
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

flag_update_export() is missing from flag_export_flags() resulting with flags that are exported without api_version => which makes them disabled => which messes up with Features => causing a WSOD.

AttachmentSize
update-flag-export-1.patch741 bytes
Login or register to post comments

Comments

#1

Posted by quicksketch on January 8, 2010 at 4:57am
Title:Update flag on flag export» Set the Flag API version on Export (Impossible to use exported flags in modules)
Priority:critical» normal
Status:needs review» fixed

Thanks Amitaibu, though running the update function on the flag probably isn't want we want. Instead I just set $flag->api_version = FLAG_API_VERSION; manually.

AttachmentSize
flag_export_version.patch 537 bytes

#2

Posted by Amitaibu on January 8, 2010 at 7:52am

I think that passing through the uodate function is a better - as it centralizes all the actions that should be taken before exporting a flag.

#3

Posted by quicksketch on January 8, 2010 at 4:13pm

The update function is intended to migrate 1.x flags to 2.x. When exporting, the flags should already be in the 2.x format. Even though the update function sets the API version too, it's only done so that Flag can discern that the flag has passed through the update.

#4

Posted by System Message on January 22, 2010 at 4:20pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.