Select widget fix for re-ordering blocks [#659584]

I think I had a problem related to http://drupal.org/node/280150

I needed to be able to re-order the blocks, similar to how View Reference works. With 6.x-1.14, you just get a single Select list, with the multiple attribute set. That doesn't allow for re-ordering (and doesn't match the other "ABC Reference" modules), which was a requirement for this project.

I used View Reference as a model and re-coded Block Reference to use the standard Select list with Multiple attribute. Autocomplete was not touched.

A patch for the fix is attached.

danielb, could you take a look at this?

Comment	File	Size	Author
#3	existing-widget.PNG	12.22 KB	puddyglum
#3	reordering-widget.PNG	4.87 KB	puddyglum
	blockreference-select-widget-fix.patch	1.99 KB	puddyglum

Comments

Comment #1

puddyglum

English

Elk Grove, CA

commented 4 January 2010 at 18:59

Does my patch fix the block re-ordering correctly? If it's a correct fix then I'd like to update this module as many of our project use it. Thanks

Comment #2

danielb commented 6 January 2010 at 05:42

It probably works but it also removes the existing widget method. It would be good if the two methods were separate.

Comment #3

puddyglum

English

Elk Grove, CA

commented 11 January 2010 at 17:23

Status	File	Size
new	reordering-widget.PNG	4.87 KB
new	existing-widget.PNG	12.22 KB

I think that since the other "'XYZ' Reference" modules use the same kind of Select list (except for the current blockreference Select list), it seems reasonable to just use the one. To help clarify what the changes I made are, I've attached screenshots showing the before and after.

Comment #4

danielb commented 11 January 2010 at 23:40

I think that since the other "'XYZ' Reference" modules use the same kind of Select list

OK I wasn't aware of that.

Comment #5

danielb commented 13 January 2010 at 04:31

I think that since the other "'XYZ' Reference" modules use the same kind of Select list

All the evidence I have found suggest Block Reference is working consistently with User Reference and Node Reference.

Select lists do not support re-ordering.

Which version of the other reference modules are you claiming allow re-ordering?

The only difference I found was the #element_validate line should not be set explicitly but this should be done:

  if (empty($element[$field_key]['#element_validate'])) {
    $element[$field_key]['#element_validate'] = array();
  }
  array_unshift($element[$field_key]['#element_validate'], 'nodereference_optionwidgets_validate');

Comment #6

danielb commented 14 January 2010 at 05:43

some more related reading

#585098: How to order item in select field ?
#234874: Setting the order of the nodes
#431270: Disallow re-ordering of node references
#406720: Allowing user to custom sort referenced nodes

I think it's a great idea to have the option available to do it, but I don't think that replacing the current method will bring it in line with the other reference modules, it will make it inconsistent with them.