Attached patch does what title says (and descriptions, should they be needed anywhere).

PS. I had to use tt() instead of notifications_tt(), as I needed i18ncontent instead of i18nstrings over here (to automatically catch up with the already-translated content type names).

Comments

boobaa’s picture

Patch updated: the block of notifications_content.module needs another go: it used the already-mentioned notifications_tt(), which I considered to be wrong (see the arguments above), thus replaced to tt().

jose reyero’s picture

Status: Needs review » Needs work

I don't understand why we cannot use notifications_tt..?

boobaa’s picture

If we are checking the availability of i18nstrings.module, we cannot be sure that the content type names gets translated (eg. even the "nodetype" textgroup may be unavailable). If we are checking i18content.module instead, the "nodetype" textgroup does exist, so we may have a better chance that the proper translations are available. Anyway, I don't know how a textgroup gets deleted - so if one enabled i18ncontent.module, translated the content type names (and descriptions), and disabled i18ncontent.module (but left i18nstrings.module enabled), the proper translations may remain available, which means it's quite enough to check the availability of tt() (ie. i18nstrings.module). On the other hand I cannot see a way to translate the content type names (and descriptions) besides using i18ncontent.module (by the means of the UI).

Correct me if I totally misunderstood something - I'm quite new to this area. If I'm convinced about the opposite (ie. that blindly using notifications_tt() is the way to go), I'll gladly reroll the patch.

boobaa’s picture

Status: Needs work » Active

Am I right that the functionality of the above patch has been already committed (and part of 2.2), at least partially? If yes, what happened to the second hunk? I don't quite seem to find how node type names and descriptions get translated. :S

jose reyero’s picture

Status: Active » Closed (won't fix)

With Notifications 2.x you may see then translated through the UI. But the message composition and sending is not really multilingual.

This will be supported for 4.x, not for 2.x