As the title says. The fix is trivial and the performance hit is nil because the single function_exists only fires on when the db does nto exist so not often so I RTBC my own.

CommentFileSizeAuthor
drupal_load_from_cache_inc_dies.patch1.47 KBchx

Comments

carlos8f’s picture

carlos8f commented 
[12:36] <carlos8f> chx: ah, nice :)  try { } doesn't actually catch fatal errors sadly.
[12:36] <carlos8f> man, if it did catch them, i might actually like PHP :)
[12:38] <chx> hehhhhhhhhh
carlos8f’s picture

carlos8f commented
Priority: Normal » Critical
chx’s picture

chx commented
Priority: Critical » Normal

Dont get overexcited this is not critical at all. This is a very edge case thing, there are VERY few things you can fire before database becomes active: settings.php and cache backend so this is not critical.

damien tournoud’s picture

damien tournoud commented

Hm. This is good, but why marking your own patch as RTBC?

chx’s picture

chx commented

Because of the reasons listed in the original post?

chx’s picture

chx commented
Status: Reviewed & tested by the community » Closed (duplicate)

#358815: drupal_get_install_files() is slow with a large tree included this fix.