Improve filter by 'billed' column in views.

I was also looking for this capability. It would help speed up billing to know what I've already billed at that level instead of having to click in, forget which I clicked on and have to go back and look again. Then on bad days or when someone walks into my office I sometimes have to click on it a third time. It gets a bit aggravating at that point. :-)

I think the code for filtering is missing from stormtimetracking.views.inc
you need to add the filter for the two fields so the code will look like:

  $data['stormtimetracking']['billable'] = array(
    'title' => t('Timetracking Billable'),
    'help' => 'Storm Timetracking Billable',
    'field' => array(
      'click sortable' => TRUE,
    ),
    'filter' => array(
      'handler' => 'views_handler_filter_boolean_operator',
    ),
    'sort' => array(
      'handler' => 'views_handler_sort',
    ),
  );
  
  $data['stormtimetracking']['billed'] = array(
    'title' => t('Timetracking Billed'),
    'help' => 'Storm Timetracking Billed',
    'field' => array(
      'click sortable' => TRUE,
    ),
    'filter' => array(
      'handler' => 'views_handler_filter_boolean_operator',
    ),
    'sort' => array(
      'handler' => 'views_handler_sort',
    ),
  );
  
  return $data;
}

Is this tested?

That seems right, but the data type in the schema is int (can't remember why - bool would be better), so I'd like to make sure that doesn't affect which filter is needed.

Doesn't seem to work for exposed filter. I think it might be a case of changing the database entry to bool.

Any chance of a patch? (http://drupal.org/patch/create)

I'm happy to put it in if it improves the situation, even if it doesn't 100% address the situation.

Please Test This!

Here's a patch using tchurch's filter and both fields identified by Mark_Watson27 (billed & billable). It was created against today's 6.x-1.x-dev. It's super simple, but should probably have some review.

I wonder if the bot was testing against the right version of Storm.

#8: billed_filter.patch queued for re-testing.

The reason that the patch is failing is because it is patched relative to the root of the drupal install rather than of storm.

Reroll from correct directory.

Have also removed the additional line breaks that were added.

Committed.

Haven't directly tested this functionality myself, but the code looks logical and seems that it works from #6 and #8.

Agreed.

thank juliangb for picking this up when I dropped out on it. :-) Awesome to see it committed!

I agree, if it could be a dropdown instead, it would be much cooler. I actually looked into some other modules looking for example code, but didn't come out with anything with the time I had.