Expose widgets as views fields

I am using WinZip to try to unzip the views.gz file. I think it should work with WinZip, but I get an "Invalid Archive Directory" error message from Winzip when unzipping the file.

Thanks franz. I found a tool to unzip the file on Windows.

Not sure why this issue got closed, its not in the 2.x branch yet as far as I can tell.

Installed the patch on the current 2.x Dev version, but the widget only seems to show up if I have selected the 'default' widget on the vote up/down settings page.

+1

nice addition :-)

Some details:

- I think this change is for vud_node, so the relevant place to implement api would be vud_node. But maybe we can make this generic for all vud submodules
- it would be great if you use the new way of theming the widget(to let theme suggestions be used), take a look to the theme calls at the actual module.

Unfortunate close. Thanks for the widget.

Thanks - great addition... Patch doesnt seem to go clean on the latest dev with patching software like Eclipse, but was applied manually with no problems and works great!

Will this be comitted to 2.x?

Thanks again, Joe

noob question...how do i use this patch file... i understand that i have to extract the files in the views folder but what about the other one?

patching can be quite difficult at first - if your on windows you can use a software called Eclipse to do it. There are a few guides somewhere on Drupal.org.

First, download the .patch file by right clicking then save link as.

If you open it up you can see the '+' lines are added and the '-' lines are subtracted - from the module listed above them.

You could do it manually, which is useful to know for small patches - but for larger patches you will want to use software...

Basically, you download Eclipse, then create a new project, then import the original files to be patched into that project.

Then click on project > apply patch, then choose your patch, then choose which files are to be patched from your workspace, and then the software will try to match them up and do the patching.

The new files will be stored wherever the Eclipse project is stored - usually c:\users\workspace\myprojecthere etc etc

Good luck!

@Desi Raaj: The official documentation http://drupal.org/patch ;-)

Thank you so much, i will give a try tomorrow and report back. i'm windows btw. Thank You.

I just made this changes a one-patch-file to make it easy to test.

I really want to make this change, but I would like to commit it when we have support for nodes, terms and comments.

I tried it, but not luck, so let me suggest about the raw patch:

+++ vud_node/views/views_handler_field_vote_up_down_widget.inc
@@ -0,0 +1,62 @@
+// $Id: ¶

use $Id$

+++ vud_node/views/views_handler_field_vote_up_down_widget.inc
@@ -0,0 +1,62 @@
+        /* ¶
+        $widget_message = t('Sorry, there was problem on the vote.');
+        if (!$can_edit) {
+          $widget_message = t('You are not allowed to vote.');
+        }
+        else if (!$vote_on_teaser) {
+          $widget_message = t('Please go to full version of this content to vote.');
+        }
+        drupal_add_js(
+          array(
+            'vud_node' => array('widget_message' => $widget_message),
+          ),
+          'setting'
+        );
+        // */

we need to change that to make this compatible to the new way to pass message: passing it to vud_widget theme function. More information about it on #807928: Use modal div instead of popup at denying vote

+++ vud_node/views/vud_node.views.inc
@@ -0,0 +1,40 @@
+// $Id:

$Id$

+++ vud_node/views/vud_node.views.inc
@@ -0,0 +1,40 @@
+  $data['vote_up_down']['table']['group'] = t('Vote up down');
+  $data['vote_up_down']['table']['join'] = array(
+    '#global' => array(),
+  );

Not sure about it, but since we do not have tables, we do not need this.

In the other hand please use Vote Up/Down as the group name

+++ vud_node/views/vud_node.views.inc
@@ -0,0 +1,40 @@
+  $data['vote_up_down']['widget'] = array(
+    'title' => t('Vote Up Down Widget'),
+    'help' => t('Provide a widget for voting up/down.'),
+    'field' => array(
+      'handler' => 'views_handler_field_vote_up_down_widget',
+    ),
+  );

A general comment, IMO we want to use vud instead of vote_up_down for namespace.

+++ vud_node/vud_node.module
@@ -293,3 +293,14 @@ function vud_node_link($type, $object, $teaser = FALSE) {
+/**
+ * Function for integrating with views 2
+ */

please use "Implementation of hook_views_api()."

Powered by Dreditor.

This is not just badly documented, but the argument is not even on hook_theme implementation. There is an argument with a message_code, which defaults to an error, please clarify this

About the specific issue you mention, I created #821048: make widgets easy to theme

About just badly documented, please provide real feedback, with specific details and/or patches to make docs better. Just say it do not help so much.

i applied the patch and the .inc file in my VUD views folder, but i cant find a "VUD Widget" field in views, did i misunderstood this patch?

Donngal: please notice the status is "needs work", also notice I mentioned in #20 the patch is not working. So feel free to provide a new verison of the patch ;-)

I applied the one from comment #12

Here is an updated patch that meets all of the comments from #20 plus some more cleanup and optimization.

What should happen after applying the patch #28? I did the following:
1. Fresh install vote_up_down-6.x-2.0-beta1
2. Apply patch #28 in the path modules/vote_up_down/vud_node with the command patch < 660258-vud-views-integration-28.patch
3. move the new files vud_handler_field_widget.inc and vud_node.views.inc to a new folder modules/vote_up_down/vud_node/views

hmm.. what should I happen next? I cannot find any new options under views... Thanks.

snecci: issues categories do not use to change, so I'm moving it back to feature request, that is the actual category of the issue. For more reference take a look at Issue submission form fields.

subscribe, would like to get this working.

@snecci You must apply the patch in the root directory of the main vud module. The folder where vud.module is located.

Thanks marvil07 and dixon_.

I applied the patch in the root directory. I guess my mistake was that I was not adding the -p0 option.

so now I did:
modules/vote_up_down$ patch -p0 < 660258-vud-views-integration-28.patch

It seems to patch the files correctly and I can see the VUD Widget under fields while creating a view, but I still cannot see the widget, just the label.

Any clues? Thanks.

Here it's an updated patch that use hook_views_data_alter() instead of hook_views_data() to avoid show this views field on not-node views. Also fixing some little naming errors.

It seems to work, for vud_node, now let's make this possible for terms and comments.

I gave it a try:

patch < fields.patch
patching file vud_node.views.inc
patching file vud_node_handler_field_widget.inc
can't find file to patch at input line 104
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git vud_node/vud_node.module vud_node/vud_node.module
|index 8db6fac..51464f7 100644
|--- vud_node/vud_node.module
|+++ vud_node/vud_node.module
--------------------------

So I tell it to patch vud_node.module...

File to patch: blah/blah/sites/all/modules/vote_up_down/vud_node/vud_node.module 
patching file blah/blah/sites/all/modules/vote_up_down/vud_node/vud_node.module

And nothing happened. Can't find any new fields or relationships, subscribing.

hobgobbler: do not forget to clear the cache. about the patch it should work using patch -p0 < file.patch

hey hey that time it worked -- I think the "-p0" did the trick

Re #38: IMHO it _is_ adequate, actually it was a suggestion by merlinofchaos, who I asked for a solution to only show the widget in some views types, while I was trying to make this.
Use exclude make us unable to prevent show on inadequate places, but we _only_ want to show the widget for nodes on node views, and I think the same for terms(only taxonomy views) and the same for comments(only comments views)

patch at #34 seems to work fine up to now, thanks marvil07 :)

mhh, id doesnt works at all for me, i get an Error: handler for vote_up_down > widget doesn't exist!

@Donngai You have to clear the cache to have Views read the new handler.

@dixon Sorry, clearing the cache doesnt solves the problem.

Edit: it works fine! made some patching mistakes, and i had to replace the function call "vud_theme_functions" on line 36 in the vud_node_handler_field_widget.inc file with "views_theme_functions".

@franz: thanks for remember me to change the status again. Like mentioned above, I would like to commit this we have support for nodes, terms and comments. Now we have complete node support, so let's do the same for terms an comments.

Anyone feel free to provide a patch, I'll be taking a look to this the next week to push it until committed ;-)

support for comments :-)

After this we only left support for taxonomy

to follow integration with vud_term, I need a clarification: #837332: use the right tag for vud_term?

Subscribe. Tried #34 patch, worked fine for nodes. Thanks.

ok, i have patched this module using the patch in #34, but is there anyway to sort it by the number of votes in views? i have defined a relationship "Node: Vote results" and tried defining a sort criteria "(Vote results) Vote results: Value desc" but it doesn't sort. please help. thank you

(Views Setup) http://img195.imageshack.us/img195/8562/screenshot20100627at122.png
(result) http://img188.imageshack.us/img188/8132/screenshot20100627at123.png

awesome, i will do so. thank you

based on #837332: use the right tag for vud_term?, for vud_term we need to make views_data_alter on node implementation of views_data, because vud_term depend on a nid for its tag.

Ok, after re-working vud_term as mentioned and updating code since #821048: make widgets easy to theme I committed this to 2.x and 3.x.

Thanks all!

BTW: I'm going to make a beta2 now ;-)

@franz: #839022: Add Views Sort Criteria

Hi all,

VUD widget does not appear for me after applying #46.

sites/all/modules/vote_up_down# patch -p0 < expose-widgets-as-views-fields_v9.patch
patching file vud_comment/views/vud_comment.views.inc
patching file vud_comment/views/vud_comment_handler_field_widget.inc
patching file vud_comment/vud_comment.module
Hunk #1 FAILED at 193.
1 out of 1 hunk FAILED -- saving rejects to file vud_comment/vud_comment.module.rej
patching file vud_node/views/vud_node.views.inc
patching file vud_node/views/vud_node_handler_field_widget.inc
patching file vud_node/vud_node.module
patching file vud_term/views/vud_term.views.inc
patching file vud_term/views/vud_term_handler_field_widget.inc
patching file vud_term/vud_term.module
Hunk #1 succeeded at 182 with fuzz 2 (offset 10 lines).

I thought this meant success, so I emptied Drupal cache (is this the cache I have to empty?), but I could not use the vud widget in views. Anyway, after this I removed files from vote_up_down/vud_node/views, and applied #34:

sites/all/modules/vote_up_down# patch -p0 < 0001-660258-Added-expose-widgets-as-views-fields.patch
patching file vud_node/views/vud_node.views.inc
patching file vud_node/views/vud_node_handler_field_widget.inc
patching file vud_node/vud_node.module
Hunk #1 succeeded at 58 (offset 10 lines).

VUD widget still does not show up in Fields. What else do I have to do?

Patch is included in latest release, just update to latest release?

Yes, thank you. Field is now accessible, but actual widget does not show up in table style. Will check later when I have time.

Changed nothing, but now widget is displayed. Must have been some cache, maybe browser...(?) As far as I remember I emptied Drupal cache.

No, it was user permissions.

Hi
I have installed 6.x-2.0-beta2 version
i am trying to show comments in a view with the vote widget , i can add the vote widget in views but i see nothing when showing the view
(it's not permission issue because i can see it in the default comment view)

is this patch got into 6.x-2.0-beta2 version or do i need to patch ?

avior: please do not hijack the issue(this is not a support issue), its status is fixed and like mentioned above it is commited to 2.x and 3.x

Hi @marvil07
My only question was
is this patch got into 6.x-2.0-beta2 version or do i need to patch ?

@aavior: as mentioned in #53 I releades beta2 after commiting this patch

But this is not on 6.x-3.0-alpha1 ? (can't see it!)

EDIT : Sorry - I misconfigured it... it works fine !