Closed (fixed)
Project:
Flash Filter
Version:
4.7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
29 May 2006 at 02:51 UTC
Updated:
14 May 2007 at 20:34 UTC
Jump to comment: Most recent file
Forgive me if I'm wrong, but on browsing the module's code, it seems that the flash-related html is placed straight into the page.
For various reasons, it should be embedded using javascript, are you aware of this tool?
http://www.osflash.org/swfobject (formerly FlashObject)
I've marked this as critical, because new versions of IE will not display flash by default.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | flash_filter.diff | 3.27 KB | arthurf |
Comments
Comment #1
tomsys commentedHi Sime,
I'll look into your proposal .. initially I'm was planning to live without JavaScript at all but now when MS has this click "thing" for a few month .. I'll be forced to use it anyway .. to make it look nice ..
Thank's for your valueable suggestion,
T.
Comment #2
owen barton commentedI would vote for SWFObject too. It is small (6KB) and seems very well thought out. It's also used by YouTube, which seems to be a strong indication of it's stability!
There are, of course other (more hacky) fixes like http://www.hoeben.net/node/135 - but these seem to have side affects in some cases.
Comment #3
simeYeah, it's certainly an issue I would rather didn't exist. Thanks for considering the suggestion.
Comment #4
arthurf commentedOk, I did this with swfobject (swfobject). I added the swfobject.js file to the flash_filter module directory
at the top of flash_filter, added this:
in function theme_flash_filter_as_movie changed the $html output to be this:
I attached a diff here as well
Comment #5
arthurf commentedAlternatively, I just created the swfobject.module. You can download it here. This allows a developer to simply do this:
The flash_filter module could support this simply by doing this in the theme_flash_filter_as_movie function:
Comment #6
hectorplus commentedI installed the FlashObject in my directory where drupal is, i added the javascript and css in the head of my page.tpl.php, then i created a page and included the script privided by FlashObject, but it doesnt show the flash file. I even added the script tag in my valid input types. No success, the FlashObject module is kinda confusing. I rather jsut install the FlashObject library. Anyone has done it?
Thanks.
Comment #7
simeThis is "not fixed" for 4.7. The upgrade path to SWF Tools includes script replacement support.
Comment #8
dries commented