There should be tests for mongodb_watchdog.

[17:47] dereine: i am not sure whether we have tests for the dblog admin screen , if not then the work is instnatly reusable as a core test. if there is such a core test then that just needs to be adjusted

CommentFileSizeAuthor
#3 mongodb_watchdog-tests.patch27.65 KBdawehner
#2 mongodb_watchdog-tests.patch26.64 KBdawehner
#1 mongodb_watchdog-tests.patch21.36 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs work
StatusFileSize
new mongodb_watchdog-tests.patch21.36 KB

Totally broken. Sadly currently together with parts of http://drupal.org/node/660460

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new mongodb_watchdog-tests.patch26.64 KB

To test this patch, apply first http://drupal.org/files/issues/mongodb_watchdog-capped.patch

Down to:

84 passes, 9 fails, 0 exceptions, and 25 debug messages
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new mongodb_watchdog-tests.patch27.65 KB

Tests are passing now, missing "feature" of the watchdog admin ui convertion.

TODO: Convert admin/reports/(not_found|access_denied) to mongodb_watchdog

dawehner’s picture

dawehner
Primary language German
commented

This patch is sure togehter with the capped stuff.

damien tournoud’s picture

damien tournoud commented
Component: Code » Watchdog

Reassigning.

chx’s picture

chx commented

I think I committed this :) I need to run 'em to see whether they pass :p commit early, commit often :D

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Needs review » Needs work

No longer applies (CVS format ?)

fgm’s picture

fgm
Primary language French
Location Paris, France
commented

The committed versions do not run currently.

The D6/D7 patches included in #1355808: Implement watchdog filter-on-insert in mongodb_watchdog include working tests for the new filter-on-insert feature.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented

Improvement added: tests no longer choke on qa.drupal.org: they are bypassed when no connection is available, so qa can still check well-formedness but not waste resources on tests that can only fail.

mgifford’s picture

mgifford
he/him
Primary language English
commented

@chx - did you commit this?

@fgm - Can we close this issue?

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Issue summary: View changes
Status: Needs work » Fixed

Well, many of the module tests no longer pass on the current dev version : Entity Query, Field Attach, and Session Handling.

So, since this is a "Watchdog" issue, it's definitely "fixed" at this point. Another issue should address broken tests in other components.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.