The site Check My Colours checks contrast ratio, brightness difference & color difference of a given site.
Garland's testing hit 114 elements:
- Luminosity Contrast Ratio: 22 failures
- Brightness difference: 12 failures
- Color difference: 44 failures
Seven's testing hit 113 elements:
- Luminosity Contrast Ratio: 20 failures
- Brightness difference: 15 failures
- Color difference: 41 failures
There are similar visibility issues with many of the themes that come with the color module & garland that I first outlined here. That issue was primarily there to provide means to check color contrast when using the color module.
Most of the color combinations provided with the color module fail:
- Blue Lagoon (Default) - Barely passes with a luminosity ratio of 4.5 - Suggest link color of #135684
- Aquamarine - Barely passes with a luminosity ratio 4.5 - Suggest text color of #565555
- Bluemarine - Barely passes with a luminosity ratio 6 - Suggest link color #294664
- Citrus Blast - Fails with a luminosity ratio of 4.2. - Suggest link color #5e4f09
- Greenbeam - Barely passes with a luminosity ratio 5.5 - Suggest link color #0d4e06
- Mercury - It's deadly both text & link color fail - Suggest link color #315061 & text color #585858
- Nocturnal - Barely passes with a luminosity ratio 5.7 - Suggested link color #46497f
- Olivia - Fails with a luminosity ratio 3.3 - Suggested link color #41561b
- Pink Plastic - Fails with a luminosity ratio 3.8 - Suggested text color #605454
- Shiny Tomato - deadly tomato both text & link color fail - Suggest link color #7b0c0c & text color #393f39
I'm not sure how to resolve this though as I'm not very good with colors and just increasing the contrast isn't going produce something that also looks good.
I wanted to bring this up as a separate issue but need to bring in a design person to suggest a better set of colors.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | screen-capture-19.png | 11.95 KB | mgifford |
| #23 | Blue_Lagoon.pdf | 304.16 KB | cliff |
| #23 | Aquamarine.pdf | 303.33 KB | cliff |
| #23 | Ash.pdf | 306.68 KB | cliff |
| #23 | Belgian_Chocolate.pdf | 304.55 KB | cliff |
Comments
Comment #1
cliffDon't have time to say much right now, but take a look at Contrast-A.
[Editing to fix name of color tool. Doh!]
Comment #2
mgiffordThanks Cliff. It's easy to find where there are problems, but I do think someone with a better sense of design should choose the alternatives.
I've got some other color tools for accessibility listed here too:
http://delicious.com/mgifford/color+accessibility
Comment #3
cliffThat rules me out. But of the color assessment tools I've found, Contrast-A seems to be best suited for a designer to use in building an accessible and aesthetically pleasing palette. Soon I'll post an explanation of how to use it here so anyone with an eye for design who follows this issue can see how to use this free tool to propose reasonable solutions. (That used to say "Later today," but Christmas preparations got away from me.)
Then I'll add the same information to the accessibility wiki you've set up (or some other appropriate place for designers to look for guidance).
Comment #4
roborn commentedsubscribe
Comment #5
jensimmons commentedsubscribe
Comment #6
mgiffordDrupal 7 really shouldn't be shipped with default themes that have accessibility issues for low vision users.
Can someone suggest options for higher contrast colors? I can write up a patch if someone else can produce a list of better colors. If anyone wants the lists of colors for these, please let me know and I can produce a broader list of what each colors are involved in each combination.
Comment #7
Bojhan commentedI am sorry, but Drupal 7 can be. As much as I would agree, that it shouldn't - the problems you proposed are very hard to fix, far harder then creating the initial list. But I do love the iniative, we should indeed look more closely into this.
Can you provide screenshots with occurrences that need to be fixed? I want to focus on fixing Seven first.
Comment #8
mgiffordComment #9
mgiffordThanks Bojhan. Here are the biggest colour challenges so far in my review of Seven using the Colour Contrast Analyzer extension for Firefox.
The "Edit Shortcuts" link fails Luminosity Contrast Ratio, Difference in Brightness, and Difference in Colour with #bbbbbb #666666
2.99:1 (fail) 85 (fail) 255 (fail)
There are problems with Difference in Colour in these combinations:
#ffffff #666666
#0074bd #e0e0d8
#5a5a5a #ffffff
Used in (on /admin/config/development/performance):
- Remove from Default shortcuts.
- Clear cache & Save configuration buttons (all buttons)
- The minimum amount of time that will elapse before the caches are recreated. (description text for FAPI)
The colour difference is defined by Juice Studios as:
(maximum (Red value 1, Red value 2) - minimum (Red value 1, Red value 2)) + (maximum (Green value 1, Green value 2) - minimum (Green value 1, Green value 2)) + (maximum (Blue value 1, Blue value 2) - minimum (Blue value 1, Blue value 2))
EDIT: Discussion of Seven moved to #740756: Ensuring Proper Color Contrast for Seven
Comment #10
mgiffordGarland has a number of issues too. Again most critical issues first.
The required for * fails #ffae00 #edf5fa
1.68:1 (fail) 64 (fail) 339 (fail)
Powered by Drupal both #898989 #ffffff & #027ac6 #ffffff fail.
Sidebar links don't have enough contrast for the size:
Log in using OpenID, Cancel OpenID login, Create new account & Request new password
#027ac6 #edf5fa 4.14:1 (AA pass for large text only) 148 (pass) 410 (fail)
The title fails the validation, but I think that's a limitation in the plugin.
Comment #11
Bojhan commentedHop by IRC sometime, to discuss this - I am unsure if we can truely solve many of these errors.
For example :
The difference between #666666 and #ffff is pretty hard to fix, as it would mean all of our descriptions become very visisble.
The difference between #0074bd and #e0e0d8 ... mean we would choose a diffrent base color for all links?
Edit Shortcuts, has been made very gray for a reason - I can understand it fails tests. I am unsure the trade off, of choosing a higher contrast is in alignment with the useage contrast design decision.
Anyways, come by IRC - we might be able to find a sweet spot where we can actually fix all of these issues. Understandably, the most critical are also the hardest to fix.
Comment #12
mgiffordHere's a sample patch for Seven. It definitely improves visibility of a few items by increasing contrast.
The only place where I really draw on the on focus is in the links. This is important for the breadcrumbs as the font is really quite small so a larger contrast is important.
'Edit shortcuts' is already using this approach and on focus/hover it's readable
Comment #13
Bojhan commentedCan you provide screenshots?
Comment #14
mgiffordSure thing.
EDITING: Adding descriptions about the images that are included. The patch I included before this does the following for Seven:
greater-contrast.png
- Gives greater contrast for the breadcrumbs on focus & hover
- Darkens the text in the buttons as well as the description text below the forum elements
greater-contrast-2.png
- Increases the contrast in the shortcuts
And yes, this is for better WCAG 2.0 support.
Comment #15
mgiffordI also ran into this problem with the contrast in the error messages.
There's enough of a window in the attachments to also show firebug/color contrast evaluation tools in the same screen.
EDIT: I also made the text bold so that it was very clear to read.
EDIT2: Adding descriptions to the images attached. Both of these were evaluated with the Firefox ColourChecker module:
screen-capture-23.png
- WCAG 2.0 AA & AAA errors with the color contrast for the Drupal warning messages
screen-capture-24.png
- Demonstration of how this would be fixed if the background was darker.
Comment #16
cliffMike, my apologies for being absent from this issue for so long. I can make a few suggestions for colors, not based on a background in design but based on my use of Contrast-A to determine the smallest change in color that will produce AAA compliance with WCAG 2.0. Using the hexadecimal values you mentioned in #9 and #10, I get these results, where the numbers in parentheses are the corresponding luminance contrast ratios for people with normal vision and these ratios exceed the WCAG minimum guideline only to the extent necessary to meet that guideline for at least some forms of colorblindness:
Again, I am making no aesthetic pronouncements. I am merely identifying the colors that will bring this theme into compliance with WCAG 2.0 while making the smallest qualitative change possible to the palette.
Comment #17
Bojhan commentedSince we are talking about visual changes, it might be easier to just provide screenshots with before / after.
Comment #18
cliffEasier for others, maybe. I'm still fighting that learning curve and don't have the time to dig into the code. I really do wish I could help more, but I am offering the information that I am able to in hopes that it will help people solve the problem.
Too little contrast seems to be endemic not just in Drupal but in modern Web design in general.
Comment #19
Everett Zufelt commentedAgree that d7 shouldn't, but will likely need to, ship with these colour issues. I notice that this issue is filed against seven. Would it be helpful to file against each core theme that has colour contrast problems to see if we can get more assistance with the issue? Perhaps that will only make it more difficult because the thread will be separeted.
Have you tested Stark as well?
Comment #20
Everett Zufelt commented@mgifford wrote: "The site Check My Colours checks contrast ratio, brightness difference & color difference of a given site"
You mention that there are a number of failures in Seven and Garland. Can you please provide us with a little more information about what test or standard is being used? I assume WCAG 2.0 AA, would that be correct?
Comment #21
mgiffordI've tried to add descriptions for 14 & 15 so that I'm more clear. And yes, these are for WCAG 2.0 AA & also AAA (although AAA's more than we can shoot for at this point).
Check My Colours I believe is checking for WCAG 2.0 primarily. Where it is compliant the screen shows AA, so I assume this is what is intended.
The initial post though was actually targeting the color module specifically. By going through the color module's array:
modules/color/color.module
And applying that to Garland's defalt schema themes/garland/color/color.inc I've just applied my suggestions to the original post.
I do hope that this clarifies things. There are tools that do fairly easily announce where there are problems with contrast. The problem outlined here #134359: Warn users about contrast problems when using the color module was that it would be good if the Color module verified color combinations, but as @webchick states, it's bad to ship when the defaults don't validate.
Comment #22
cliffI'm not set up to do screenshots of a site displaying a number of different color schemes, but I can provide the electronic equivalent of the color chips you can get at the paint store. Each of the attached PDFs is like a set of paint chips for one of the problematic color pairs @mgifford identified in 9 and 10. In each case:
Taken together, these images show the kinds of changes that will produce WCAG-compliant degrees of contrast. I hope that someone who is more facile than I with theming and Drupal can use this information to create at least one screenshot each of Seven and Garland with these or equally effective fixes implemented.
Comment #23
cliffFor those who need visuals, these are the color schemes @mgifford referred to in 21. Each color scheme is named for the corresponding set of color combinations, or "palette," for Garland as obtained from the color module. These color combinations were mentioned in the introduction to this issue.
Each palette includes images I will call "color chips," arranged in this order:
Information in each PDF file explains the symbols used and the color combination's degree of compliance (or failure to comply) with WCAG 2.0. (My apologies if the words and labels in these PDFs are not themselves accessible. I have no control over the tool that created the PDFs and did not have time to remediate them.)
Comment #24
Bojhan commentedHeh, as much as I appriciate this I think we are all looking for these context - in the Seven theme.
Comment #25
mgifford@Bojhan, can you comment on #14 & #15 which are focused on the admin side.
Most of these color comment issues in this thread are targeting Garland's color schemes. The last comment by Cliff is focused on Garland's scheme's for color pallets. Thanks for this Cliff!
Comment #26
seutje commentedsubscribe, can we split off garland, or split off seven and set this issue to Garland theme component?
Comment #27
mgifford@seuje good call.
I created #740756: Ensuring Proper Color Contrast for Seven and have renamed this one.
Removed Seven from Component & tags.
Comment #28
kat3_drx commentedI have a patch up for review for the "Edit shortcuts" link native to the Shortcuts toolbar here #795268: Shortcut "Edit shortcuts" link has insufficient color contrast ratio.
Would love some review/critique. This is my first time originating an issue and patch. *bundle of nerves*
Comment #29
mgiffordThis is still an issue for the pre-defined color schemes.
Comment #30
Jeff Burnz commentedI don't think we can fix this - its a monumental task requiring a lot of design changes & reviews. We can leave this open but frankly its just too late.
I realize peeps probably don't want to hear that but we should have thought about this 18 months ago, in which case things may have been quite different, however for D7 I think we have to let this go, and simply remove Garland from core in D8.
Comment #31
mgiffordIt was thought about 9 months ago, but agreed that it's a pretty huge challenge.
It certainly should be something that is addressed in D8 and I'm willing to bump as a criterion for future versions.
Comment #32
mgiffordAre we going to be dropping Garland in D8? I'd hoped so, but...
Comment #33
mgiffordLooks like Garland's getting removed from core later in the week.