improvements:
- removed code duplication
- added "Delegate roles" action

CommentFileSizeAuthor
D7_port_role_delegation.patch14.41 KBpasqualle

Comments

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Status: Fixed » Needs review

[edit: download link removed]

david lesieur’s picture

david lesieur commented
Status: Needs review » Fixed

Excellent patch committed!
The new actions are a welcome addition.

Status: Needs review » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Title: D7 port of role_delegation » Port to D7
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Closed (fixed) » Active

Coming from http://www.bywombats.com/blog/01-23-2010/delegating-role-delegation#comm...

Sorry, but no :)

Looking at the current CVS HEAD... http://drupalcode.org/viewvc/drupal/contributions/modules/role_delegatio...

...the code is still using the workaround of a separate page.

In #118345: Revamp hook_user_form/_register/_validate/_submit/_insert/_update, I made sure that modules like Role Delegation can easily alter the user account form and apply the changes directly, instead of using a separate page.

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Status: Active » Postponed (maintainer needs more info)

@sun: the user account form is altered and changes applied directly (in hook_user_presave), the separate page is used only when the user do not have the 'access user profiles' permission..

david lesieur’s picture

david lesieur commented
Status: Postponed (maintainer needs more info) » Fixed

The intended behavior works as described by Pasqualle in #5.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.