icons are not showing up - only the description text is

when going to properties it is clear why:

node/add is inserted in the path to the images instead of just /modules/quicktags/xxxx_xx.png

CommentFileSizeAuthor
#13 closetags-patch0.txt435 bytespwolanin
#5 66099_base_path_addition.patch.txt702 bytesBèr Kessels

Comments

lennart’s picture

lennart commented

I have now tried enabling base url in settings.php - still same issue

lennart’s picture

lennart commented
Title: icons missing » icons missing when using Clean URLs

Now I hav also disabled clean urls - that did it. Now it works, but it would be nice if it also worked with clean urls enabled

Bèr Kessels’s picture

Bèr Kessels commented
Status: Active » Closed (duplicate)

http://drupal.org/node/65596

Bèr Kessels’s picture

Bèr Kessels commented
Assigned: Unassigned » Bèr Kessels
Status: Closed (duplicate) » Active

Sorry, that issue appeared to be duplicate, but in fact dealt with two issues. We should discuss the missing icons here.

Bèr Kessels’s picture

Bèr Kessels commented
StatusFileSize
new 66099_base_path_addition.patch.txt702 bytes

Can anyone confirm that the attached patch fixes this missing icons issue?

Bèr Kessels’s picture

Bèr Kessels commented
Status: Active » Needs review

I need coffee. sorry. :/

ckclarke’s picture

ckclarke commented

I can confirm this patch has fixed the missing icons issue. Thanks Ber.

ckclarke’s picture

ckclarke commented
Status: Needs review » Reviewed & tested by the community

Apparently I need coffee too.

Bèr Kessels’s picture

Bèr Kessels commented
Status: Reviewed & tested by the community » Fixed

Fixed in 4.7 and HEAD, thanks.

lennart’s picture

lennart commented
Title: icons missing when using Clean URLs » "Close Tags" icon missing when using Clean URLs
Status: Fixed » Active

the "Close Tags" icon is still missing. All the other icons are working fine now. Thanks

Bèr Kessels’s picture

Bèr Kessels commented
Priority: Normal » Critical
nikkiana’s picture

nikkiana commented

I dunno if this is helpful or not, but I had the same issue with the "Close Tags" icon missing, and I changed the code on line 149 and it seemed to fix it...

the code was orginally
$path = drupal_get_path('module','quicktags');

and I changed it to
$path = base_path() . drupal_get_path('module','quicktags') .'/';

pwolanin’s picture

pwolanin commented
StatusFileSize
new closetags-patch0.txt435 bytes

I just installed the module today (module file dated May 30)- and this still seems to be a problem with the "Close Tags" icon.

Attached patch essentially as per #12 gets the icon to appear, but I do see any evidence that clicking the icon has any effect.

Oh wait- just looked at the Js source and now I see. It only closes tags that were added via quicktags. I guess that's much simpler to implement, but seems counter-intuitive and not very useful...

pwolanin’s picture

pwolanin commented
Status: Active » Needs review

oops- forgot to indicate patch in status

naudefj’s picture

naudefj commented
Status: Needs review » Reviewed & tested by the community

Yip, this patch fixed the problem. Please commit ASAP.

$ patch -p0 <x.patch
patching file quicktags.module
Hunk #1 succeeded at 153 (offset 7 lines).
lennart’s picture

lennart commented

I can confirm this works

Bèr Kessels’s picture

Bèr Kessels commented
Version: 4.7.x-1.x-dev » master
Status: Reviewed & tested by the community » Fixed

fixed in HEAD

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)