I just tried Blueprint out for a couple of small sites and was enjoying using it until I noticed that your template.php seems to take control of $vars['head_title'] without giving any kind of option to the user.
I understand its now popular for themes to start implementing better SEO page titles - however may I please suggest that you wrap the code that does this with something like if (module_exists('page_title')) {... }? Otherwise your theme completely takes over and gives my module no opportunity to work (unless in my subtheme I call page title manually which means Page Title sets the title, Blueprint resets it and my subtheme sets it back)...
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | blueprint.page_title.unbreak.patch | 2.27 KB | nicholasthompson |
Comments
Comment #1
nicholasthompsonThis patch seems to fix it for me... Of course, it will still break for any other module which uses
hook_preprocess_page()to set the head_title itself...Just my personal opinion here (ie, I'm happy to be corrected!) but I think its very bad practice for a theme to start playing with the page title like this. Surely this is something much better left to the Module layer in Drupal? Hence the existence of the Page Title module...
Comment #2
designerbrent commentedThank you so much for your review of the theme as well as for kindly providing a patch to fix it. I have applied this to both the 1.x and the 2.x branches and committed them. (2.x and 1.x)
As to the why that Blueprint does this: the idea is to improve the site theme in a basic, logical way, without the overhead of added modules. I'm happy to incorporate checks for your module for those that want to move up to the more customizable elegance that your Page Title offers.
Comment #4
jjma commentedUpdated to the latest Blueprint 1.2 and Page Titles but the only page that is being set is the front page. All other pages, views are not being set by the module.
Comment #5
designerbrent commentedjjma: This issue is for the 6.x-2.x branch. If you download the dev version, you will see the changes. That is where all the development is happening.