Closed (fixed)
Project:
Views (for Drupal 7)
Version:
6.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
16 Dec 2009 at 22:23 UTC
Updated:
1 Feb 2010 at 22:40 UTC
Jump to comment: Most recent file
Comments
Comment #1
dagmarHere is the patch. And the error messages before and after applied the patch.
Comment #2
dagmarHere is the complete patch for all error handlers in ajax.js
Comment #3
merlinofchaos commentedLet's generalize the error function so that we are not duplicating as much code.
Comment #4
dawehnerIt would be cool, if the regexes have some inline comments, what they do. But thats optional the rest is fine.
Comment #5
dagmarLets try this patch
Comment #6
merlinofchaos commentedI'm not actually sure this needs to be ported to D7. Maybe we need to submit something like this to D7 core as an improvement to the AJAX framework.
In any case, I improved the error handling slightly and am going to put this in CTools as well.
It's worth noting that behavior is going to change from server to server. For example, mine is configured in such a way that it does not actually send error messages during PHP crashes, so I added a little note to help point people to the right place in that circumstance.
Commited this patch to 2.x and 3.x.
Comment #7
damien tournoud commentedThere is nothing to port, most of that is gone.