we are using vid to connect a node (revision) to location-data

but this module thinks we are doing this by nid!

critical because location_views useles because of this!

quick and easy patch...

CommentFileSizeAuthor
vid_instead_nid.patch.txt639 bytesTobias Maier

Comments

karens’s picture

I just want to think this through since none of the other views examples have been using vid. You're probably right, but I'll get back to you on this.

I've set up a separate project for the location_views module to make it easier to track bugs and feature requests. Moving this issue to that page.

karens’s picture

Project: Location » Location Views
Version: 6.x-3.x-dev »

Forgot to move the issue...

karens’s picture

I went ahead and put this change in the latest cvs. It seems logical, I just can't figure out why other views modules aren't doing it. I'm not really using revisions, so I welcome feedback on whether or not it's working right.

karens’s picture

Status: Needs review » Fixed

Forgot to change status, reopen if there are problems.

Tobias Maier’s picture

vid == version id

location uses vid because someone may change the nodes' location between the revisions
this means the location is linked to a specific vid of a node-nid

your filter looks which vid fits to the current vids in the node table
vid and nid are the primary keys in the node-table
both are unique

i hoped this helped to understand the issue

karens’s picture

I understand what the vid is and how it works, and like I said, it makes sense to use it. I was just wondering why other examples did not use it and whether that was a signal that there is some reason not to. Anyway, it's in there now, so if everything seems to work right, then it was the right way to do it :-)

Anonymous’s picture

Status: Fixed » Closed (fixed)