Fields don't show after selecting biblio type

Do you have any caching turned on?

The only other thing I can think of is some other module is resetting the $form_state['storage'] array. If I recall correctly I ran into this with the ctools module.

I'm having the same problem. It appeared in version 6.x-1.8 and is still there in the latest dev version. The probleme is there when I try to create a new biblio item or to edit one that already exist. I tried to desactived all my modules but it didn't help. I even tried installing biblio in an localhost setup whit no other modules activated, but that din't help either.

Denis

Strange, I haven't seen this on any of the machines I test on. What version of Drupal and PHP are you guys using?

PHP 5.2
Drupal 6.14

Hmmm, this is going to require a little debugging on your part 'cause I still can't reproduce it.

One thing to try first would be to add a "default:" case to the switch in the validate function, so could you add a line after line 1554 in the biblio.module file, like this and see if that makes any difference...

      ....

      else {
        form_set_error('bibtex_data',t('There does not appear to be any bibtex data to work with '));
        return;
      }
      break;
    case t('Save'):  // <---- Line 1554
    default:           // <---- ADD THIS LINE

      if ($form_state['storage']['biblio_type'] == $form_state['values']['biblio_type'] ||
         (!empty($form['#node']->biblio_type) && $form['#node']->biblio_type == $form_state['values']['biblio_type']))
      {
        unset ($form_state['storage']);
      }
      else {
        $form_state['storage']['biblio_type']  = $form_state['values']['biblio_type'];
        $form_state['submitted'] = TRUE;
        return;
      }

    ...

In my case, the problem seem to be cause by the Local module. I've came to this conclusion after desactivating/activating my modules. With Locale desactivated, Biblio works fine, but it I activate this module the problem reappers. Maybe meneteqel should try to desactivate this module on his installation...

Ahhh, I know what the problem is now! At the beginning of the biblio_form_validate function there are some lines like this...

function biblio_form_validate($form, & $form_state) {

  $op = isset($form['#post']['op'])?$form['#post']['op'] :
        ($form['#post']['biblio_type'] > 0 ? 'Save' : '');

that should be changed to this...

function biblio_form_validate($form, & $form_state) {

  $op = isset($form['#post']['op'])?$form['#post']['op'] :
        ($form['#post']['biblio_type'] > 0 ? t('Save') : '');  // <-- NOTE the "Save" in this line is now wrapped in the t() function.

Yep, that did the trick for me! Thank you very much!

I tried the suggested changes but it didn't help me. I'm still having the same problem.

I've tried as Administrator and as standard user. Running Drupal 6.15 and PHP 5.2.9

Could you try the latest -dev version (http://ftp.drupal.org/files/projects/biblio-6.x-1.x-dev.tar.gz) and see if it works.

Hmmm, looks like I'm going to have to make another release pretty soon since this is a rather nasty bug :-(

I'm going to call this fixed with this commit... http://drupal.org/cvs?commit=303866