In D6 we are using an empty field for language to indicate language neutral. In D7, the standard zxx code is being used for the Field API.

Let's start using that instead of an empty field - probably will perform better and be easier to use.

CommentFileSizeAuthor
#15 apachesolr-language-neutral-662232-D5.patch5.06 KBclaudiu.cristea
#10 und-662232-10.patch1.71 KBpwolanin
#2 use-zxx-662232-2.patch6.16 KBpwolanin
#1 use-zxx-662232-1.patch4.13 KBpwolanin

Comments

pwolanin’s picture

pwolanin commented
Status: Active » Needs review
StatusFileSize
new use-zxx-662232-1.patch4.13 KB
pwolanin’s picture

pwolanin commented
StatusFileSize
new use-zxx-662232-2.patch6.16 KB

slightly revised per discussion w/ Robert.

pwolanin’s picture

pwolanin commented
Version: 6.x-1.x-dev » 6.x-2.x-dev
Status: Needs review » Patch (to be ported)

committed to 6.x-1.x

anarchivist’s picture

anarchivist commented
Status: Patch (to be ported) » Needs work

If I recall right, 'zxx' doesn't actually mean language neutral; instead, it means "no linguistic content."

pwolanin’s picture

pwolanin commented
Status: Needs work » Patch (to be ported)

@anarchivist - D7 uses that code for Language neutral for all of Field API - feel free to argue with Dries...

anarchivist’s picture

anarchivist commented

Thanks for the heads up - will look for an issue there...

anarchivist’s picture

anarchivist commented

See #635094: Unify "language neutral" language codes for further discussion...

robertdouglass’s picture

robertdouglass commented
Version: 6.x-2.x-dev » 5.x-2.x-dev

Committed to 6.2. The patch won't apply cleanly without #401234: Reflect hierarchical taxonomy vocabulary in facet, so it either has to be adapted for 5.2, or #401234 has to go in first.

pwolanin’s picture

pwolanin commented
Version: 5.x-2.x-dev » 6.x-1.x-dev
Status: Patch (to be ported) » Needs work

D7 core now changed 'zxx' to 'und'

pwolanin’s picture

pwolanin commented
StatusFileSize
new und-662232-10.patch1.71 KB
pwolanin’s picture

pwolanin commented
Status: Needs work » Needs review
robertdouglass’s picture

robertdouglass commented

Looks good.

pwolanin’s picture

pwolanin commented
Version: 6.x-1.x-dev » 6.x-2.x-dev
Status: Needs review » Patch (to be ported)

committed to 6.x-1.x

robertdouglass’s picture

robertdouglass commented
Version: 6.x-2.x-dev » 5.x-2.x-dev

#662232 by pwolanin | anarchivist: Changed Use language-neutral code like D7.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Patch (to be ported) » Fixed
StatusFileSize
new apachesolr-language-neutral-662232-D5.patch5.06 KB

Committed to DRUPAL-5--2, in #318070.

Attached the patch.

EDIT: Changed to "und"

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jpmckinney’s picture

jpmckinney commented
Status: Closed (fixed) » Patch (to be ported)

Also fixed in apachesolr_commentsearch in 6-2 http://drupal.org/cvs?commit=360110

Change code style in 6-1 to match 6-2 http://drupal.org/cvs?commit=360114

jpmckinney’s picture

jpmckinney commented
Status: Patch (to be ported) » Fixed

apachesolr_commentsearch doesn't exist in other versions, nothing to port.

Removed TODO in 6-1 and 5-2
http://drupal.org/cvs?commit=360716
http://drupal.org/cvs?commit=360714

Change code style
http://drupal.org/cvs?commit=360730

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.