Remove PIFR_SERVER_TEST_RESULT_* constants entirely.

Comments

boombatower’s picture

Assigned: Unassigned » boombatower

Locations that need fixing.

./review/simpletest/pifr_simpletest.module:14:define('PIFR_SERVER_TEST_RESULT_SETUP', 1);
./review/simpletest/pifr_simpletest.module:15:define('PIFR_SERVER_TEST_RESULT_FETCH', 2);
./review/simpletest/pifr_simpletest.module:16:define('PIFR_SERVER_TEST_RESULT_CVS', 3);
./review/simpletest/pifr_simpletest.module:17:define('PIFR_SERVER_TEST_RESULT_PATCH', 4);
./review/simpletest/pifr_simpletest.module:18:define('PIFR_SERVER_TEST_RESULT_APPLY', 5);
./review/simpletest/pifr_simpletest.module:19:define('PIFR_SERVER_TEST_RESULT_SYNTAX', 6);
./review/simpletest/pifr_simpletest.module:20:define('PIFR_SERVER_TEST_RESULT_INSTALL', 7);
./review/simpletest/pifr_simpletest.module:21:define('PIFR_SERVER_TEST_RESULT_TEST', 8);
./review/simpletest/pifr_simpletest.module:22:define('PIFR_SERVER_TEST_RESULT_FAIL', 9);
./review/simpletest/pifr_simpletest.module:23:define('PIFR_SERVER_TEST_RESULT_PASS', 10);
./server/pifr_server.test:236:    $this->nextTest($client_test, TRUE, PIFR_SERVER_TEST_RESULT_FAIL);
./server/pifr_server.test:272:  protected function nextTest(array $client, $expect, $test_result = PIFR_SERVER_TEST_RESULT_PASS) {
./pifr.install:286:      if ($test_result['code'] >= PIFR_SERVER_TEST_RESULT_FAIL) {
./pifr.install:360:      return PIFR_SERVER_TEST_RESULT_FETCH;
./pifr.install:362:      return PIFR_SERVER_TEST_RESULT_CVS;
./pifr.install:364:      return PIFR_SERVER_TEST_RESULT_APPLY;
./pifr.install:366:      return PIFR_SERVER_TEST_RESULT_INSTALL;
./pifr.install:368:      return PIFR_SERVER_TEST_RESULT_TEST;
./pifr.install:372:    return PIFR_SERVER_TEST_RESULT_SYNTAX;
./pifr.install:377:            PIFR_SERVER_TEST_RESULT_PASS : PIFR_SERVER_TEST_RESULT_FAIL;
./pifr.install:390:    case PIFR_SERVER_TEST_RESULT_FETCH:
./pifr.install:392:    case PIFR_SERVER_TEST_RESULT_CVS:
./pifr.install:394:    case PIFR_SERVER_TEST_RESULT_APPLY:
./pifr.install:396:    case PIFR_SERVER_TEST_RESULT_INSTALL:
./pifr.install:398:    case PIFR_SERVER_TEST_RESULT_SYNTAX:
./pifr.install:400:    case PIFR_SERVER_TEST_RESULT_TEST:
./pifr.install:402:    case PIFR_SERVER_TEST_RESULT_FAIL:
./pifr.install:403:    case PIFR_SERVER_TEST_RESULT_PASS:
./client/pifr_client.test:48:    $this->assertEqual($result['code'], PIFR_SERVER_TEST_RESULT_PASS, t('Core review passed. (@message)',
./pifr_server.xmlrpc.inc:298: *     'code', // Summary result code, PIFR_SERVER_TEST_RESULT_*.
./pifr_server.test.inc:325:    if ($result['code'] == PIFR_SERVER_TEST_RESULT_PASS) {
./pifr_server.test.inc:722:        $message = $status['code'] == PIFR_SERVER_TEST_RESULT_PASS ? 'pass' : 'fail';
boombatower’s picture

Status: Active » Needs review
StatusFileSize
new5.01 KB

Both tests need updating as a whole anyway so leaving them untouched.

boombatower’s picture

Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.