Some of the style issues I've noticed in going over the code:

- indentation (too much in content_retriever_admin_types_form for example)
- spacing around string concatenation: the . operator takes a space either side
- coddled elses: an else comes on a new line, and it doesn't indent any further than the if.
- missing spaces after function arguments

CommentFileSizeAuthor
#3 662624.content_distribution.cleanup-3-coddled-else-more.patch8.35 KBjoachim
#2 662624.content_distribution.cleanup-2-coddled-else.patch10.95 KBjoachim
#1 662624.content_distribution.cleanup-1-if-spaces.patch26.13 KBjoachim

Comments

joachim’s picture

joachim commented
StatusFileSize
new 662624.content_distribution.cleanup-1-if-spaces.patch26.13 KB

Result of 

perl -pi -e 's[(foreach|if|while)\(][$1 (];' `grep -ril '<?php' *`
perl -pi -e 's[\){][) {];' `grep -ril '<?php' *`

Looks sane; committing.

More to do, so keeping this issue active.

joachim’s picture

joachim commented
StatusFileSize
new 662624.content_distribution.cleanup-2-coddled-else.patch10.95 KB

patch 2: coddled elses, elseif not else if, and some indentation in nearby areas.

Also looks sane; committing :D

joachim’s picture

joachim commented
StatusFileSize
new 662624.content_distribution.cleanup-3-coddled-else-more.patch8.35 KB

Either I missed some or I didn't apply that patch correctly.

Anyway: more coddled elses. Committed this patch.