Option to disable notifications not available for unpublished nodes [#662808]

I could swear that I saw an option at one point to "Don't send notification" in the node options when creating a new node. I am not sure if this option was coming from notification module or notifications extra but for the life of me I can't find this option now.

I desperately need a way to turn off custom subscription new node notification on a per node basis. Then, when the node is ready, turn on the notification to be sent to all subscribers.

How can this be accomplished?

Comments

Comment #1

danepowell commented 9 February 2010 at 23:51

Status:

Active

» Postponed (maintainer needs more info)

1) You must have the "skip notifications" permission
2) The content notifications module must be enabled
3) Notifications must already be enabled for your node action type - i.e., you won't see the 'disable notifications' option for a node update if notifications are only enabled for node creations.
4) Failing 1-3, try the latest releases of Notifications, Messaging, and notifications_extra, which fix bugs similar to this.

Does that help?

Comment #2

3cwebdev commented 10 February 2010 at 14:53

Thank you for your reply. I finally realized what was confusing me. As you pointed out, the option to 'not send' is not there for a node update. This is a little strange for our workflow because we will work on a node over several days, leaving it in an unpublished state. So technically it is an update, but we have never published so we consider it a draft. When it comes time to publish it then option to not send the notification is not there.

Is there a way to leave the option set to send notifications for node publish only (not update) and still have the option not not send notifications available until after the node has been published. If not, is this a feature that could/should be added?

Comment #3

danepowell commented 11 February 2010 at 14:43

Notifications will never be sent for nodes in an unpublished state, AFAIK. When you change the node from unpublished to published, this counts as a "node creation" as far as Notifications is concerned, and notifications will be sent if that global option is enabled. However, you won't have the opportunity to disable notifications for that node. So basically you are requesting that the option to "disable notifications" be present on unpublished nodes so that publishing them won't trigger node creation notifications, is that correct? Sounds reasonable.

Comment #4

3cwebdev commented 11 February 2010 at 17:24

Yes, that is exactly correct. I believe it would be b beneficial to have an option on unpublished node to "Disable Notification" for that node. This would allow a workflow of working on an unpublished node through multiple edits and then once we are ready to change it's status to Published there would be an option to disable sending a notification for that node.

Thanks for you attention to this and possible consideration as a feature request. This is not a show-stopper for us but but be a great option. Please let me know if I can provide any further info or assistance.

Comment #5

danepowell commented 18 February 2010 at 23:43

Title:	Option to not send notifications when creating a node.	» Option to disable notifications not available for unpublished nodes
Project:	Notifications Add-ons	» Notifications
Component:	Custom subscriptions	» User interface
Category:	support	» bug
Status:	Postponed (maintainer needs more info)	» Active

To recap, Notifications treats nodes moving from unpublished to published state as creation. Thus, if sending notifications on node creation is enabled, there should be an option to disable notifications for unpublished nodes. This option doesn't exist because of the conditional in notifications_content.module line 151. I think that conditional just needs to be modified slightly to fix this. (I suspect this is a regression caused by #359507: Hide "Disable Notifications" checkbox for when notifications are disabled)

Comment #6

mrtoner commented 10 March 2010 at 04:25

Notifications will never be sent for nodes in an unpublished state, AFAIK. When you change the node from unpublished to published, this counts as a "node creation" as far as Notifications is concerned, and notifications will be sent if that global option is enabled.

Just so that I'm clear (this isn't germane to the issue, but since you brought this up): "Notifications for node creation" happens whenever a node is published, and a node that is published multiple times will result in multiple notifications?

If this is a bug -- particularly one that can be fixed -- I'll be glad to open another issue. I spent a good chunk of time setting up a series of Rules that would publish a node if certain criteria were met and unpublish the node if an update caused that criteria to fail, only to find that when the node was published again (corrections were made during an update) another notification was sent. I'm wanting a "node created" message sent only the first time the content is published (node updates and comments won't trigger notifications on my site).

Comment #7

danepowell commented 10 March 2010 at 14:18

mrtoner - it would seem that way, yes. I would suggest opening another issue. Without giving it too much thought, I think a good solution would be a checkbox along the lines of "permanently disable notifications for this node."

Comment #8

wqmeng commented 17 March 2010 at 09:42

+1, We may check the status of a node when send out message, if the node is publishded then process the send queue item and not when the node is unpublished. While another problem is if there are too many unpublished nodes so there will be many send quene items too, this may cause performance problem somewhere.