can't create container subdirectories, or edit container directories [#662870]

i found two slightly different, though i assume related, bugs having to do with directories for storage containers. (this might also be related to http://drupal.org/node/590350 ...)

first, when creating a new container you can't use a directory if the directory's parent doesn't already exist. (that is, i can't use /sites/all/files/foo/bar if /sites/all/files/foo doesn't already exist.) if you try, the form fails to submit, with no visible error/message. (this stumped me for a while as i wanted /sites/all/files/storage/video .)

also, for existing containers, if you try to edit the directory path, the path is updated, but the directory isn't created.

in both cases, it seems that an intelligible printed message would do the trick. sorry i didn't include a patch for that yet. (and my testing was only done with the "Filesystem / Drupal" service -- not sure if this would be relevant to any others.)

thanks for all of your work on this module and bd_video, jbrown!

Comments

Comment #1

arh1 commented 18 December 2009 at 04:50

Version:

6.x-1.x-dev

» 6.x-1.0

ugh (hit Preview, not Save!) -- changing the version number.

Comment #2

jbrown commented 18 December 2009 at 05:34

Version:

6.x-1.0

» 6.x-1.x-dev

http://php.net/mkdir now has a $recursive option, but D6 doesn't use it. D7 does.

I say we just add an error message for this and it will be fixed in D7

The logic for editing containers is that you have to move them manually, then update the config. The form should say this.
If a service supports automated container moving (none do atm), then there should be a checkbox.

Comment #3

arh1 commented 18 December 2009 at 15:46

just adding a clear error message or two sounds great to me.

to clarify, the combination of these two issues means that if i want to use e.g. /sites/all/files/storage/video , i need to create a container pointing to /sites/all/files/storage first, then delete it and create the container pointing to /sites/all/files/storage/video . (unless you're able to manually create /sites/all/files/storage beforehand as the same user on the server that PHP/Drupal runs as.)