Loving this module/idea.

Here's a patch adding the ability to call numbers based on a URL. You already had the callnumber menu item and in this implementation I'm trying to follow the coding techniques of this module.. Is there a reason why this hasn't been done? It's only a few lines so I'm guessing there's a problem I'm not thinking about?

Ideally I might change hook_menu a little bit and avoid arg(2).

Also, I wonder if we should be sending these links to forms requiring the user to POST. For example, it's a bit of a problem that you can do:

Only local images are allowed. to make current users call themselves when they view the page.

And with this patch:
Only local images are allowed.

CommentFileSizeAuthor
asterisk-callnumber.patch715 bytesslip

Comments

slip’s picture

slip commented

The example that got cut out:

<img src='/asterisk/callme' />
hunmonk’s picture

hunmonk commented

there are a lot of issues with the module -- i had planned a rewrite, but really don't have time for it now. it's doubtful i'll look at this in the near future, but thanks for the input, if/when i get back to making progress here, i'll be sure to look at it.